You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/20 08:46:37 UTC

[GitHub] [flink] sunjincheng121 edited a comment on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API

sunjincheng121 edited a comment on issue #8681: [FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API
URL: https://github.com/apache/flink/pull/8681#issuecomment-503937624
 
 
   Hi @WeiZhong94 thanks for the PR. I have not for the deep look the PR. just find that the `test_stream_execution_environment_completeness` fails for Test fail:  
   `Exception: Methods: {'getStreamGraphGenerator'} in Java class org.apache.flink.streaming.api.environment.StreamExecutionEnvironment have not been added in Python class <class 'pyflink.streaming.stream_execution_environment.StreamExecutionEnvironment'>`
   So I think `PythonAPICompletenessTestCase#get_java_class_methods` should be improved. 
   and should not contains `private` method check. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services