[GitHub] [beam] tvalentyn commented on a change in pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

[GitBox <gi...@apache.org>]

tvalentyn commented on a change in pull request #12145:
URL: https://github.com/apache/beam/pull/12145#discussion_r456206985



##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1982,17 +1982,25 @@ class BeamModulePlugin implements Plugin<Project> {
         return argList.join(' ')
       }
 
-      project.ext.toxTask = { name, tox_env ->
+      project.ext.toxTask = { name, tox_env, needsExpansionServiceJar = false ->
+        project.evaluationDependsOn(":sdks:java:io:expansion-service")
         project.tasks.create(name) {
           dependsOn 'setupVirtualenv'
           dependsOn ':sdks:python:sdist'
+          if (needsExpansionServiceJar) {
+            dependsOn ':sdks:java:io:expansion-service:shadowJar'
+          }
 
           doLast {
             // Python source directory is also tox execution workspace, We want
             // to isolate them per tox suite to avoid conflict when running
             // multiple tox suites in parallel.
             project.copy { from project.pythonSdkDeps; into copiedSrcRoot }
-
+            if (needsExpansionServiceJar) {
+              def expansionServiceJar =  project.project(':sdks:java:io:expansion-service').shadowJar.archivePath
+              def expansionServiceDestinationDir = "${copiedSrcRoot}/sdks/java/io/expansion-service/build/libs"

Review comment:
       Why to we need a jar in tox (unit test) suite?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org