You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/03/20 20:26:46 UTC

[GitHub] [fluo-muchos] ata18 opened a new pull request #334: Adds systemd support for accumulo(2.x) services

ata18 opened a new pull request #334: Adds systemd support for accumulo(2.x) services
URL: https://github.com/apache/fluo-muchos/pull/334
 
 
   - This change adds systemd unit files for all accumulo 2.x services and
   ansible scripts to start/stop these services using systemd.
   - Adds accumulo-cluster-systemd script (modified version of
   accumulo-culster script) to use systemd to start/stop
   the cluster when systemd is enabled via muchos.props file.
   - Copies the modified file to bin and soft links it to
   bin/accumulo-cluster
   - Removes accumulo-service script as it becomes irrelevant as services
   could now be started/stopped via systemctl commands directly.
   - Adds support to have multiple tservers per host when systemd is enabled
   and the number of tservers can be configured via muchos.props file.
   - Updates the muchos.props.example file to show usage.
   
   Will submit a follow up PR to have systemd support for hadoop(3.x) and
   zookeeper services.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ata18 commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ata18 commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606360825
 
 
   @ctubbsii Thanks for reviewing. I have made the changes you have suggested earlier. When you have some time can you please take a look again?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r401221621
 
 

 ##########
 File path: ansible/roles/accumulo/templates/tserver.j2
 ##########
 @@ -0,0 +1,24 @@
+[Unit]
+Description=TServer Service for Accumulo
+Requires=network.target 
+After=network.target
+
+[Service]
+User={{ cluster_user }}
+Group={{ cluster_group }}
+Type=simple
+ExecStart={{ accumulo_home }}/bin/accumulo tserver{{''}}
 
 Review comment:
   Is `{{''}}` still needed on the end of this line?
   
   ```suggestion
   ExecStart={{ accumulo_home }}/bin/accumulo tserver
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r401222593
 
 

 ##########
 File path: ansible/wipe-systemd.yml
 ##########
 @@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+- hosts: accumulomaster
+  gather_facts: false
+  become: yes
+  tasks:
+  - name: "disable all accumulo systemd services on master"
+    systemd:
+      name: "{{ item }}"
+      state: stopped
+      enabled: no
+    with_items:
+      - "accumulo-master.service"
+      - "accumulo-monitor.service"
+      - "accumulo-gc.service"
+      - "accumulo-tracer.service"
+    register: stop_disable_service
+    failed_when: "stop_disable_service is failed and 'Could not find the requested service' not in stop_disable_service.msg"
+
+  - name: "remove accumulo systemd units"
+    file: path="/etc/systemd/system/-*" state=absent
 
 Review comment:
   I think this is a typo:
   
   ```suggestion
       file: path="/etc/systemd/system/accumulo-*" state=absent
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ata18 commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ata18 commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606409034
 
 
   > Hi @ata18 ; I looked it over, and it looks like you incorporated most of my suggestions, except for the dash instead of underscore in the unit file names.
   
   Ah, I might have overlooked it last time. Will submit another iteration

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii edited a comment on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ctubbsii edited a comment on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606876301
 
 
   @arvindshmicrosoft I'll defer to your insight into regarding convenience. I don't find them necessary or convenient on their own with systemd (just more to maintain that don't provide additional function)... but I do see it in the context of the consistent "Muchos experience" that @keith-turner mentioned.
   
   The main reason I even have any of this as a concern is because I'm interpreting the new script as fitting within the context of what we might call "a systemd experience" within Muchos, and I don't see this script as very systemd-like.
   
   However, if the goal here is to create a consistent "Muchos experience", then my thoughts are a bit different, since the current "Muchos experience" is most certainly already centered around `accumulo-cluster`. In fact, I was going to suggest clobbering the `accumulo-cluster` script with the systemd variant to make the systemd and non-systemd variants even more consistent... but I see that's already being done (as a symlink).
   
   So... I guess I don't really have any objections here. Thanks for talking it through. :smiley_cat: 
   
   (FWIW, I actually think the systemd experience is better overall... and would love to see Muchos drop the non-systemd experience entirely at some point. I don't see a good argument for keeping the non-systemd deployment if the systemd variant meets all the needs. It might simplify things to just do systemd.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] keith-turner commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
keith-turner commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606737617
 
 
   > in order to dissuade people from the idea that these scripts were part of "the Accumulo experience".
   
   I think it would be better to anchor this discussion around the much narrower "Muchos experience" rather than the broad  "Accumulo experience".  As someone who has run many many Accumulo release test using Muchos in the past and hope to continue doing so, I really like the approach taken in this PR because it decreases my cognitive load (there is already a lot to think of when running a release test) when using Muchos.  Also the soft link from accumulo-cluster to accumulo-cluster-systemd in bin lets anyone doing an ls know something is up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606956367
 
 
   > > FWIW, I actually think the systemd experience is better overall.
   > 
   > I hope this enhancement leads to the ability to use cluster agitation tools like Chaos Monkey to kill and restart VMs during testing. With systemd when a VM is restarted, it should automatically restart services.
   
   systemctl also has a restart command to agitate, if you needed to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ata18 commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ata18 commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606410301
 
 
   > I was curious if you had tested this in the single-tserver case and in the multiple tserver case.
   
   yes, I have tested both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services
URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r396120256
 
 

 ##########
 File path: ansible/roles/accumulo/files/accumulo-cluster-systemd
 ##########
 @@ -0,0 +1,348 @@
+#! /usr/bin/env bash
 
 Review comment:
   I would recommend passing this script through shellcheck, just to see if it detects any potential problems.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services
URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r396122905
 
 

 ##########
 File path: ansible/roles/accumulo/templates/tserver.j2
 ##########
 @@ -0,0 +1,26 @@
+[Unit]
+Description=TServer Service for Accumulo
+Requires=network.target 
+After=network.target
+
+[Service]
+User={{ cluster_user }}
+Group={{ cluster_group }}
+Type=simple
+ExecStart={{ accumulo_home }}/bin/accumulo tserver{% if accumulo_major_version == '1' %}-{{ tserver_instance_id }}{% endif %}{{''}}
+Environment=ACCUMULO_HOME={{ accumulo_home }}
+Environment=JAVA_HOME={{ java_home }}
+{% if accumulo_major_version == '2' %}
+Environment=ACCUMULO_SERVICE_INSTANCE={{ tserver_instance_id }}
+{% endif %}
 
 Review comment:
   If systemd templating is used, you don't need to use the ansible templating here for the tserver_instance_id. You can instead use `%I` (or `%i`):
   
   https://fedoramagazine.org/systemd-template-unit-files/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606461180
 
 
   > This is like a wrapper function for ssh + systemctl commands and gives a unified experience for users of accumulo-cluster script.
   
   I like that framing as a "unified experience". It's a useful concept. I'm just not sure this is a useful experience to unify. Unifying around the systemd tooling, to strengthen that experience, seems like it would be more useful here than duplicating the experience of the `accumulo-cluster` script, which I still see as somewhat "experimental". Unifying around one might mean more divergence from the other.
   
   Also, I think it is a mistake to think of the provided cluster management scripts as being "*the* Accumulo experience" (to copy), rather than "*an* Accumulo experience" (to swap out as needed). That's something we explicitly wanted to avoid with the script refactor, which was heavily motivated by a desire to remove *prescriptive* experiences in favor of empowering downstream consumers to create *tailored* experiences more easily. I wish I had argued harder about keeping these scripts in the contrib directory (or even in a separate repo), in order to dissuade people from the idea that these scripts were part of "*the* Accumulo experience".
   
   **If** it is not a requirement to preserve the unified experience of `accumulo-cluster` (and I really don't think it is, or should be), the question for me becomes: "is it still useful to preserve any of that experience". For me, I just haven't found a compelling utility that can't just as easily be provided with `pssh` and `systemctl`, making me think we don't actually need the experience of this script in Muchos.
   
   Sorry if any of that was too incoherent. Here's a prime number of cats to reward anybody who made it this far: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: :smiley_cat: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ata18 commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ata18 commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606412044
 
 
   > Also, I'm not sure I understand the need for the `accumulo-cluster-systemd` script. I was hoping to take a more thorough look at that when I had a chance. My first thought, though, is that it would be easier to run `pssh` for most things that script does than to try to adapt the `accumulo-cluster` script from Accumulo's out-of-box cluster management tool. Or, at the very least, a much simpler script based on `pssh` and `systemctl`. I'd have to take a deeper look into what the script is actually providing for Muchos, though.
   
   This is like a wrapper function for ssh + systemctl commands and gives a unified experience for users of accumulo-cluster script.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] arvindshmicrosoft merged pull request #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft merged pull request #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services
URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r396122068
 
 

 ##########
 File path: ansible/roles/accumulo/templates/gc.j2
 ##########
 @@ -0,0 +1,23 @@
+[Unit]
+Description=GC Service for Accumulo
+Requires=network.target 
+After=network.target
 
 Review comment:
   Is Hadoop and ZK also using systemd in this scenario? If so, it'd be good to run after those. If not, I wonder if Accumulo will start too early.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services
URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r396122068
 
 

 ##########
 File path: ansible/roles/accumulo/templates/gc.j2
 ##########
 @@ -0,0 +1,23 @@
+[Unit]
+Description=GC Service for Accumulo
+Requires=network.target 
+After=network.target
 
 Review comment:
   Are Hadoop and ZK also using systemd in this scenario? If so, it'd be good to run after those. If not, I wonder if Accumulo will start too early.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ata18 commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services

Posted by GitBox <gi...@apache.org>.
ata18 commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services
URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r397513556
 
 

 ##########
 File path: ansible/roles/accumulo/files/accumulo-cluster-systemd
 ##########
 @@ -0,0 +1,348 @@
+#! /usr/bin/env bash
 
 Review comment:
   Will do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ata18 commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ata18 commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606409413
 
 
   > it was a bit hard to tell what exactly changed, since you force pushed to your branch, and that marks all previous review comments as "Obsolete" and starts the review process over from scratch (GitHub won't show the diffs between updates, and the intermediate refs disappear from the repo, so it's hard to check them out manually for direct comparison on the command-line). In general, please avoid force-pushing when updating a PR after reviewers have commented.
   
   Sorry, it was a force of habit. I will keep in mind to not repeat this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606369345
 
 
   > @ctubbsii Thanks for reviewing. I have made the changes you have suggested earlier. When you have some time can you please take a look again?
   
   Hi @ata18 ; I looked it over, and it looks like you incorporated most of my suggestions, except for the dash instead of underscore in the unit file names. However, it was a bit hard to tell what exactly changed, since you force pushed to your branch, and that marks all previous review comments as "Obsolete" and starts the review process over from scratch (GitHub won't show the diffs between updates, and the intermediate refs disappear from the repo, so it's hard to check them out manually for direct comparison on the command-line). In general, please avoid force-pushing when updating a PR after reviewers have commented. I can try to take a closer look at what changed tomorrow.
   
   I was curious if you had tested this in the single-tserver case and in the multiple tserver case.
   
   Also, I'm not sure I understand the need for the `accumulo-cluster-systemd` script. I was hoping to take a more thorough look at that when I had a chance. My first thought, though, is that it would be easier to run `pssh` for most things that script does than to try to adapt the `accumulo-cluster` script from Accumulo's out-of-box cluster management tool. Or, at the very least, a much simpler script based on `pssh` and `systemctl`. I'd have to take a deeper look into what the script is actually providing for Muchos, though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] keith-turner commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
keith-turner commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606896485
 
 
   > FWIW, I actually think the systemd experience is better overall.
   
   I hope this enhancement leads to the ability to use cluster agitation tools like Chaos Monkey to kill and restart VMs during testing.  With systemd when a VM is restarted, it should automatically restart services.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ata18 commented on a change in pull request #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ata18 commented on a change in pull request #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r400600674
 
 

 ##########
 File path: ansible/roles/accumulo/templates/tserver.j2
 ##########
 @@ -0,0 +1,26 @@
+[Unit]
+Description=TServer Service for Accumulo
+Requires=network.target 
+After=network.target
+
+[Service]
+User={{ cluster_user }}
+Group={{ cluster_group }}
+Type=simple
+ExecStart={{ accumulo_home }}/bin/accumulo tserver{% if accumulo_major_version == '1' %}-{{ tserver_instance_id }}{% endif %}{{''}}
+Environment=ACCUMULO_HOME={{ accumulo_home }}
+Environment=JAVA_HOME={{ java_home }}
+{% if accumulo_major_version == '2' %}
+Environment=ACCUMULO_SERVICE_INSTANCE={{ tserver_instance_id }}
+{% endif %}
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ata18 commented on a change in pull request #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ata18 commented on a change in pull request #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r400600574
 
 

 ##########
 File path: ansible/roles/accumulo/tasks/start-tserver.yml
 ##########
 @@ -0,0 +1,33 @@
+#
+### Licensed to the Apache Software Foundation (ASF) under one or more
+### contributor license agreements.  See the NOTICE file distributed with
+### this work for additional information regarding copyright ownership.
+### The ASF licenses this file to You under the Apache License, Version 2.0
+### (the "License"); you may not use this file except in compliance with
+### the License.  You may obtain a copy of the License at
+###
+###    http://www.apache.org/licenses/LICENSE-2.0
+###
+### Unless required by applicable law or agreed to in writing, software
+### distributed under the License is distributed on an "AS IS" BASIS,
+### WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+### See the License for the specific language governing permissions and
+### limitations under the License.
+###
+##
+- name: install accumulo tserver systemd unit file
+  template:
+    src: roles/accumulo/templates/tserver.j2 
+    dest: "/etc/systemd/system/accumulo_tserver_{{ item }}.service"
 
 Review comment:
   I have accommodated this suggestion in this iteration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services
URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r396122631
 
 

 ##########
 File path: ansible/roles/accumulo/tasks/start-tserver.yml
 ##########
 @@ -0,0 +1,33 @@
+#
+### Licensed to the Apache Software Foundation (ASF) under one or more
+### contributor license agreements.  See the NOTICE file distributed with
+### this work for additional information regarding copyright ownership.
+### The ASF licenses this file to You under the Apache License, Version 2.0
+### (the "License"); you may not use this file except in compliance with
+### the License.  You may obtain a copy of the License at
+###
+###    http://www.apache.org/licenses/LICENSE-2.0
+###
+### Unless required by applicable law or agreed to in writing, software
+### distributed under the License is distributed on an "AS IS" BASIS,
+### WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+### See the License for the specific language governing permissions and
+### limitations under the License.
+###
+##
+- name: install accumulo tserver systemd unit file
+  template:
+    src: roles/accumulo/templates/tserver.j2 
+    dest: "/etc/systemd/system/accumulo_tserver_{{ item }}.service"
 
 Review comment:
   Rather than use custom naming like this, it would be better to leverage systemd's built-in templating:
   https://fedoramagazine.org/systemd-template-unit-files/
   
   Using a filename like `/etc/systemd/system/accumulo_tserver@{{ item }}.service` to symlink to a single file for all tservers would match systemd conventions a bit better. Even without the symlink, using the `@argument` naming convention will be more familiar to systemd users.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] arvindshmicrosoft commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606723671
 
 
   @ctubbsii thank you for your insight - based on our other conversations from last week I agree with your guidance that the experience provided by the `accumulo-cluster` script is _one_ option and not the _only_ option for customers. When we worked on this, the philosophy we had was ease of use and minimize surprises to unsuspecting users - by retaining a familiar command-line interface so that someone who uses `accumulo-cluster` to stop (let's say) TServer(s) on a node, is not taken by surprise when they find that (in the systemd case) the desired effect was not achieved and systemd just restarted the said TServer(s). Having used a variant of these modified scripts internally for a few months now, I personally can say that it does prove very convenient when restarting Accumulo cluster / TServers for example - simply because as an user we do not have to remember to use another script or syntax. So respectfully I think from a productivity p.o.v. I think this approach (of modifying accumulo-cluster) proves more convenient for end users of Muchos for dev / test scenarios.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on issue #334: Adds systemd support for accumulo services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #334: Adds systemd support for accumulo services
URL: https://github.com/apache/fluo-muchos/pull/334#issuecomment-606876301
 
 
   @arvindshmicrosoft I'll defer to your insight into regarding convenience. I don't find them necessary or convenient on their own with systemd (just more to maintain that don't provide additional function)... but I do see it in the context of the consistent "Muchos experience" that @keith-turner mentioned.
   
   The main reason I even have any of this as a concern is because I'm interpreting the new script as fitting within the context of what we might call "a systemd experience" within Muchos, and I don't see this script as very systemd-like.
   
   However, if the goal here is to create a consistent "Muchos experience", then my thoughts are a bit different, since the current "Muchos experience" is most certainly already centered around `accumulo-cluster`. In fact, I was going to suggest clobbering the `accumulo-cluster` script with the systemd variant to make the systemd and non-systemd variants even more consistent... but I see that's already being done (as a symlink).
   
   So... I guess I don't really have any objections here. Thanks for talking it through. :smiley_cat: 
   
   (FWIW, I actually think the systemd experience is better overall... and would love to see Muchos drop the non-systemd experience entirely at some point. I don't see a good argument for keeping the non-systemd deployment if the systemd variant meets all the needs. It might simplify things just do systemd.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #334: Adds systemd support for accumulo(2.x) services
URL: https://github.com/apache/fluo-muchos/pull/334#discussion_r397536587
 
 

 ##########
 File path: ansible/roles/accumulo/templates/gc.j2
 ##########
 @@ -0,0 +1,23 @@
+[Unit]
+Description=GC Service for Accumulo
+Requires=network.target 
+After=network.target
 
 Review comment:
   Nevermind. Accumulo is robust enough to wait on these services, and there's no guarantee that they'll be running on the current node anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services