You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/05/09 09:07:19 UTC
[GitHub] codecov-io commented on issue #346: SCB-565 Register instance with
the same id will create redundant endpoint index data
codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346#issuecomment-387674481
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr&el=h1) Report
> Merging [#346](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/f55a89ceacb4bebf79c33c917402076b2aeaed2d?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
- Coverage 69.92% 69.47% -0.46%
==========================================
Files 17 17
Lines 3412 3420 +8
==========================================
- Hits 2386 2376 -10
- Misses 861 880 +19
+ Partials 165 164 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `71.13% <100%> (ø)` | :arrow_up: |
| [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `48.92% <77.77%> (+1.17%)` | :arrow_up: |
| [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `53.92% <0%> (-2.62%)` | :arrow_down: |
| [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `77.25% <0%> (+0.42%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr&el=footer). Last update [f55a89c...a3883fe](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services