You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "jennifer-xiong25 (via GitHub)" <gi...@apache.org> on 2026/03/19 07:05:26 UTC
[PR] Move setLastReconciledSpec to after successful transition start [flink-kubernetes-operator]
jennifer-xiong25 opened a new pull request, #1072:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1072
## Summary
- Move `setLastReconciledSpec()` to after `startTransition()` and `startSavepointRedeployTransition()` succeed, so it's not stamped if the transition fails
- Previously, `lastReconciledSpec` was set before the transition call — if the transition failed or was later aborted, `lastReconciledSpec` reflected the new spec while the active child still ran the old one. Subsequent deploys would see no diff and fall into PATCH_CHILD (in-place upgrade) instead of a proper B/G transition
- Add assertion in `verifySavepointFetchFailureRecovery` confirming `lastReconciledSpec` does not contain the failed spec change
## Context
Slack thread: https://shopify.enterprise.slack.com/archives/C0ALAR1TLP8
## Test plan
- [x] `verifySavepointFetchFailureRecovery` passes with new assertion
- [x] Full B/G controller test suite passes (72 tests)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move setLastReconciledSpec to after successful transition start [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #1072:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1072#issuecomment-5191101750
I created a JIRA ticket: https://issues.apache.org/jira/browse/FLINK-40333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move setLastReconciledSpec to after successful transition start [flink-kubernetes-operator]
Posted by "jhung-lyft (via GitHub)" <gi...@apache.org>.
jhung-lyft commented on PR #1072:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1072#issuecomment-4769708321
Hi @gyfora, thanks for checking in! Just to clarify, I cherry-picked @jennifer-xiong25's fix internally, so she'll still be driving this pr to completion here.
Also, we found and fixed another bug (stale status.upgradeSavepointPath causing JM to restore from an old savepoint on retry). We’d love to submit this upstream as a follow-up PR once our internal CLA process is cleared up. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move setLastReconciledSpec to after successful transition start [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #1072:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1072#issuecomment-4177851485
cc @schongloo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move setLastReconciledSpec to after successful transition start [flink-kubernetes-operator]
Posted by "jennifer-xiong25 (via GitHub)" <gi...@apache.org>.
jennifer-xiong25 closed pull request #1072: Move setLastReconciledSpec to after successful transition start
URL: https://github.com/apache/flink-kubernetes-operator/pull/1072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move setLastReconciledSpec to after successful transition start [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #1072:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1072#issuecomment-5176719944
Are you guys still working on this? It would be nice to merge it this week for the upcoming release. Please create a JIRA ticket for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move setLastReconciledSpec to after successful transition start [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #1072:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1072#issuecomment-4769835892
thanks @jhung-lyft , looking forward to it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move setLastReconciledSpec to after successful transition start [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #1072:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1072#issuecomment-4333794557
can you please open a jira ticket for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move setLastReconciledSpec to after successful transition start [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #1072:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1072#issuecomment-4177847446
How do these 2 PRs relate to each other? Should we close one?
https://github.com/apache/flink-kubernetes-operator/pull/1072
https://github.com/apache/flink-kubernetes-operator/pull/1076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move setLastReconciledSpec to after successful transition start [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #1072:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1072#issuecomment-4765882673
@jennifer-xiong25 @jhung-lyft would be nice if we could wrap this PR up and get the fix in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org