You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/02 01:59:39 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
cloud-fan commented on a change in pull request #28696:
URL: https://github.com/apache/spark/pull/28696#discussion_r433580261
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
##########
@@ -588,36 +602,41 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
}
test("filter pushdown - timestamp") {
- // spark.sql.parquet.outputTimestampType = TIMESTAMP_MILLIS
- val millisData = Seq(
- Timestamp.valueOf("1000-06-14 08:28:53.123"),
- Timestamp.valueOf("1582-06-15 08:28:53.001"),
- Timestamp.valueOf("1900-06-16 08:28:53.0"),
- Timestamp.valueOf("2018-06-17 08:28:53.999"))
- withSQLConf(SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key ->
- ParquetOutputTimestampType.TIMESTAMP_MILLIS.toString) {
- testTimestampPushdown(millisData)
- }
-
- // spark.sql.parquet.outputTimestampType = TIMESTAMP_MICROS
- val microsData = Seq(
- Timestamp.valueOf("1000-06-14 08:28:53.123456"),
- Timestamp.valueOf("1582-06-15 08:28:53.123456"),
- Timestamp.valueOf("1900-06-16 08:28:53.123456"),
- Timestamp.valueOf("2018-06-17 08:28:53.123456"))
- withSQLConf(SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key ->
- ParquetOutputTimestampType.TIMESTAMP_MICROS.toString) {
- testTimestampPushdown(microsData)
- }
-
- // spark.sql.parquet.outputTimestampType = INT96 doesn't support pushdown
- withSQLConf(SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key ->
- ParquetOutputTimestampType.INT96.toString) {
- import testImplicits._
- withParquetDataFrame(millisData.map(i => Tuple1(i)).toDF()) { implicit df =>
- val schema = new SparkToParquetSchemaConverter(conf).convert(df.schema)
- assertResult(None) {
- createParquetFilters(schema).createFilter(sources.IsNull("_1"))
+ Seq(true).foreach { java8Api =>
Review comment:
Seq(true, false)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org