You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Paul King (JIRA)" <ji...@apache.org> on 2019/07/15 13:30:00 UTC
[jira] [Resolved] (GROOVY-8547) Factory pattern side-stepped by
CompilerConfiguration/ParserVersion
[ https://issues.apache.org/jira/browse/GROOVY-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul King resolved GROOVY-8547.
-------------------------------
Resolution: Fixed
Assignee: Paul King
Fix Version/s: 3.0.0-beta-3
Proposed PR merged. Thanks!
> Factory pattern side-stepped by CompilerConfiguration/ParserVersion
> -------------------------------------------------------------------
>
> Key: GROOVY-8547
> URL: https://issues.apache.org/jira/browse/GROOVY-8547
> Project: Groovy
> Issue Type: Improvement
> Components: parser
> Reporter: Eric Milles
> Assignee: Paul King
> Priority: Minor
> Fix For: 3.0.0-beta-3
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It seems to me the selection of the Antlr2 or Antlr4 parser could be implemented within a default implementation of {{ParserPluginFactory}} instead of introducing {{ParserVersion}} with separate get/set on {{CompilerConfiguration}}. I don't see the need for static factory methods {{antlr2()}} and {{antlr4()}} on {{ParserPluginFactory}}, their use from {{CompilerConfiguration}} and the strange class loading in {{ParserPluginFactory}}.
> The factory pattern appears to me to be side-stepped in favor of a version constant. Is there still meaning in offering a config option of setting a {{ParserPluginFactory}}? Has this been used ever in the past?
> Couldn't this suffice for a default in {{CompilerConfiguration}}? Then {{ParserVersion}} could be dropped.
> {code:java}
> public ParserPluginFactory getPluginFactory() {
> if (pluginFactory == null) {
> pluginFactory = new ParserPluginFactory() {
> @Override
> public ParserPlugin createParserPlugin() {
> return Boolean.getBoolean(GROOVY_ANTLR4_OPT) ? new Antlr4ParserPlugin() : new AntlrParserPlugin();
> }
> }
> }
> return pluginFactory;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)