You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by jaltekruse <gi...@git.apache.org> on 2016/01/28 19:09:32 UTC
[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...
GitHub user jaltekruse opened a pull request:
https://github.com/apache/drill/pull/343
DRILL-2653: Improve web UI experience when there is an error in a sto…
…rage plugin configuration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaltekruse/incubator-drill 2653-web-ui-storage-plugin-conf-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/343.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #343
----
commit 3d12ac5d97f32657643196ade616643fa62735e5
Author: Jason Altekruse <al...@gmail.com>
Date: 2016-01-28T18:01:30Z
DRILL-2653: Improve web UI experience when there is an error in a storage plugin configuration
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/343#issuecomment-176375367
That's fine, Jason :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/343#issuecomment-176312248
@sudheeshkatkam @jacques-n Can you please review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/343#issuecomment-176437904
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/343#issuecomment-176434681
@sudheeshkatkam Message fixed, also added more colors :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/343#discussion_r51185648
--- Diff: exec/java-exec/src/main/resources/rest/storage/update.ftl ---
@@ -53,8 +53,17 @@
});
function doUpdate() {
$("#updateForm").ajaxForm(function(data) {
- $("#message").removeClass("hidden").text(data.result).alert();
- setTimeout(function() { location.reload(); }, 800);
+ var messageEl = $("#message");
+ messageEl.addClass("hidden");
+ // Wait a fraction of a second before showing the message again. This
+ // makes it clear if a second attempt gives the same error as
+ // the first that a "new" message came back from the server
+ setTimeout(function() {
+ messageEl.removeClass("hidden").text("Please retry: " + data.result).alert();
--- End diff --
Originally I didn't have the "Please retry:" I had added that after finding your patch. Previously, it would just show either the error or the success message and only in the case of the success message reload. Will push a fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/343#issuecomment-176314047
@sudheeshkatkam Just saw that you actually had a patch for this, I was looking at DRILL-2663 originally, and found the duplicate DRILL-2653 when I went to write the commit message. I think I'll merge this version because it is a little clearer for users in the case of repeated failures, but I didn't mean to ignore your patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2653: Improve web UI experience when the...
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/343#discussion_r51177764
--- Diff: exec/java-exec/src/main/resources/rest/storage/update.ftl ---
@@ -53,8 +53,17 @@
});
function doUpdate() {
$("#updateForm").ajaxForm(function(data) {
- $("#message").removeClass("hidden").text(data.result).alert();
- setTimeout(function() { location.reload(); }, 800);
+ var messageEl = $("#message");
+ messageEl.addClass("hidden");
+ // Wait a fraction of a second before showing the message again. This
+ // makes it clear if a second attempt gives the same error as
+ // the first that a "new" message came back from the server
+ setTimeout(function() {
+ messageEl.removeClass("hidden").text("Please retry: " + data.result).alert();
--- End diff --
This alert will show even if the update succeeds, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---