You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by DrIgor <gi...@git.apache.org> on 2017/01/26 13:26:23 UTC
[GitHub] zeppelin pull request #1949: [MINOR] Refactor to modern apis
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/1949
[MINOR] Refactor to modern apis
### What is this PR for?
Use modern api to write less and try-with-resources to close file in case of errors
### What type of PR is it?
Refactoring
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DrIgor/zeppelin file-loading-refactoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1949
----
commit d1ee8a1f96f7426efd01b53148e98db16f856554
Author: Igor Drozdov <ig...@epam.com>
Date: 2017-01-26T13:22:45Z
Refactor to modern apis
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1949: [MINOR] Refactor to modern apis
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1949
@Leemoonsoo Of course! Unfortunately, build log is truncated and I can't find out why it failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1949: [MINOR] Refactor to modern apis
Posted by DrIgor <gi...@git.apache.org>.
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1949
[MINOR] Refactor to modern apis
### What is this PR for?
Use modern api to write less and try-with-resources to close file in case of errors
### What type of PR is it?
Refactoring
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DrIgor/zeppelin file-loading-refactoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1949
----
commit d1ee8a1f96f7426efd01b53148e98db16f856554
Author: Igor Drozdov <ig...@epam.com>
Date: 2017-01-26T13:22:45Z
Refactor to modern apis
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1949: [MINOR] Refactor to modern apis
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1949: [MINOR] Refactor to modern apis
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1949
LGTM and merge to master if no more comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1949: [MINOR] Refactor to modern apis
Posted by DrIgor <gi...@git.apache.org>.
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1949
[MINOR] Refactor to modern apis
### What is this PR for?
Use modern api to write less and try-with-resources to close file in case of errors
### What type of PR is it?
Refactoring
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DrIgor/zeppelin file-loading-refactoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1949
----
commit d1ee8a1f96f7426efd01b53148e98db16f856554
Author: Igor Drozdov <ig...@epam.com>
Date: 2017-01-26T13:22:45Z
Refactor to modern apis
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1949: [MINOR] Refactor to modern apis
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1949
```
Tests in error:
InterpreterRestApiTest.testRestartInterpreterPerNote:303 NullPointer
```
It's a known bug https://issues.apache.org/jira/browse/ZEPPELIN-1856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1949: [MINOR] Refactor to modern apis
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1949: [MINOR] Refactor to modern apis
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1949
@DrIgor Thanks for the contribution!
CI fails with known flaky test https://issues.apache.org/jira/browse/ZEPPELIN-1856. @DrIgor Could you trigger ci again and see if it passes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1949: [MINOR] Refactor to modern apis
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---