[GitHub] [beam] chamikaramj commented on a change in pull request #17009: [BEAM-14016] Fixed flaky postcommit test

[GitBox <gi...@apache.org>]

chamikaramj commented on a change in pull request #17009:
URL: https://github.com/apache/beam/pull/17009#discussion_r819835033



##########
File path: sdks/python/apache_beam/io/gcp/experimental/spannerio.py
##########
@@ -1247,14 +1253,17 @@ def process(self, element):
           else:
             raise ValueError("Unknown operation action: %s" % m.operation)
           batch_func(**m.kwargs)
-
-      self.service_metric.call('ok')
     except (ClientError, GoogleAPICallError) as e:
-      self.service_metric.call(str(e.code.value))
+      for service_metric in self.service_metrics.values():
+        service_metric.call(str(e.code.value))

Review comment:
       Should we only be updating metrics for the tables that we tried to update here ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org