You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/21 11:31:04 UTC
[GitHub] [skywalking] lijial opened a new issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
lijial opened a new issue #6045:
URL: https://github.com/apache/skywalking/issues/6045
Dear skywalking team,
While reading skywalking agent code(version 8.3.0) and I notice in ArrayBlockingQueueBuffer.java,
save() method, when strategy is IF_POSSIBLE, there only **queue.offer(data)** without catch clause .
As queue.offer() may throw an exception, this may interrupt TracingContext.stopSpan() upward.
Is it a bug?
Should I suggest to add catch clause for calling offer() ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6045: ArrayBlockingQueueBuffer is activated unexpected in the IF_POSSIBLE mode
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6045:
URL: https://github.com/apache/skywalking/issues/6045
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial commented on issue #6045: ArrayBlockingQueueBuffer is activated unexpected in the IF_POSSIBLE mode
Posted by GitBox <gi...@apache.org>.
lijial commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-749013854
> Also, note, the exception(NPE) wouldn't happen, as in SkyWalking, no one should put a NULL into the queue, right?
Yes, that is right after checking it carefully
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6045: ArrayBlockingQueueBuffer is activated unexpected in the IF_POSSIBLE mode
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-749259677
Merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6045: ArrayBlockingQueueBuffer is activated unexpected in the IF_POSSIBLE mode
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-749025991
> Also, note, the exception(NPE) wouldn't happen, as in SkyWalking, no one should put a NULL into the queue, right?
I thought there's something wrong in the constructor(DataCarrierTest:testProduce() Line 60 ) .
And also DataCarrierTest:testBlockingProduce() method
https://github.com/apache/skywalking/commit/09c0e8e32d643eb8a4189225925389ab0e483252#diff-552816423049ee3be17a365cfcdc999a9af8f27bac814bcdcfb310faab82aa01L50
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748958519
Also, note, the exception(NPE) wouldn't happen, as in SkyWalking, no one should put a NULL into the queue, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748932386
In this pic below, as red box shows, so I still hold the doubt as topic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748953263
@wu-sheng Dear
After init in Channels.java as you mention above, then next, code will run to boot() method as pic,
bufferChannels would be set to new BufferStrategy as L68 : _carrier.setBufferStrategy(BufferStrategy.IF_POSSIBLE);_
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TraceSegmentServiceClient.java#L63-L69
so line 45 will be execute runtime
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/ArrayBlockingQueueBuffer.java#L42-L55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748953263
@wu-sheng Dear
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TraceSegmentServiceClient.java#L63 to L69
After init in Channels.java as you mention above, then next, code will run to boot() method as pic,
_carrier.setBufferStrategy(BufferStrategy.IF_POSSIBLE);_
so this line will be execute runtime
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/ArrayBlockingQueueBuffer.java#L45
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748953263
@wu-sheng Dear
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TraceSegmentServiceClient.java#L63-L69
After init in Channels.java as you mention above, then next, code will run to boot() method as pic,
_carrier.setBufferStrategy(BufferStrategy.IF_POSSIBLE);_
so this line 45 will be execute runtime
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/ArrayBlockingQueueBuffer.java#L42-L55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial commented on issue #6045: ArrayBlockingQueueBuffer is activated unexpected in the IF_POSSIBLE mode
Posted by GitBox <gi...@apache.org>.
lijial commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-749011710
> Oh, this is a very serious bug we haven't detected for a very long time. Actually, the issue is, strategy determines the channel implementation. In the `if_possible`, should be `Buffer` rather than `ArrayBlockingQueueBuffer`.
>
> So, the change should be **remove** `DataCarrier#setBufferStrategy` method, and require `BufferStrategy` in the constructor.
>
> Are you willing to fix this issue?
I'm willing to fix the issue, I would pull add commit a pr later, thank you for give me the chance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial commented on issue #6045: ArrayBlockingQueueBuffer is activated unexpected in the IF_POSSIBLE mode
Posted by GitBox <gi...@apache.org>.
lijial commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-749034882
> Is my pull request resolving your concern?
Yes, after compiling and testing , now it is fit expectation
And what I think code below would be delete, right?
https://github.com/apache/skywalking/blob/10772d388e12d2e79f999b2e084d9dd94771a56a/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/ArrayBlockingQueueBuffer.java#L44-L45
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748928269
I think if possibleb strategy is not using ArrayBlockingQueueBuffer. Could you recheck?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6045: ArrayBlockingQueueBuffer is activated unexpected in the IF_POSSIBLE mode
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-749027498
Is my pull request resolving your concern?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial commented on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748953263
@wu-sheng Dear
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TraceSegmentServiceClient.java#L63 to 69
After init in Channels.java as you mention above, then next, code will run to boot() method as pic,
_carrier.setBufferStrategy(BufferStrategy.IF_POSSIBLE);_
so this line will be execute runtime
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/ArrayBlockingQueueBuffer.java#L45
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748953263
@wu-sheng Dear
After init in Channels.java as you mention above, then next, code will run to boot() method as pic,
bufferChannels would be set new BufferStrategy as L68 : _carrier.setBufferStrategy(BufferStrategy.IF_POSSIBLE);_
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TraceSegmentServiceClient.java#L63-L69
so this line 45 will be execute runtime
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/ArrayBlockingQueueBuffer.java#L42-L55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748953263
@wu-sheng Dear
After init in Channels.java as you mention above, then next, code will run to boot() method as pic,
_carrier.setBufferStrategy(BufferStrategy.IF_POSSIBLE);_
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TraceSegmentServiceClient.java#L63-L69
so this line 45 will be execute runtime
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/ArrayBlockingQueueBuffer.java#L42-L55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748953263
@wu-sheng Dear
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TraceSegmentServiceClient.java#L63-L69
After init in Channels.java as you mention above, then next, code will run to boot() method as pic,
_carrier.setBufferStrategy(BufferStrategy.IF_POSSIBLE);_
so this line will be execute runtime
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/ArrayBlockingQueueBuffer.java#L42-L55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6045: ArrayBlockingQueueBuffer is activated unexpected in the IF_POSSIBLE mode
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-749038690
Logically yes. If you want, feel free to send another pull request to fix after #6048 merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748928269
I think if possible strategy is not using ArrayBlockingQueueBuffer. Could you recheck?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748943143
Ha, I see. There are 2 separate things.
1. From a tech perspective, there should be an NPE catch. If you want, this should be fixed. Welcome to send a pull request.
2. In the real world, this condition will never execute, take a look at here, https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/Channels.java#L38-L42.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748953263
@wu-sheng Dear
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TraceSegmentServiceClient.java#L63-L69
After init in Channels.java as you mention above, then next, code will run to boot() method as pic,
_carrier.setBufferStrategy(BufferStrategy.IF_POSSIBLE);_
so this line will be execute runtime
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/ArrayBlockingQueueBuffer.java#L45
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748953263
@wu-sheng Dear
After init in Channels.java as you mention above, then next, code will run to boot() method as pic,
L68: _carrier.setBufferStrategy(BufferStrategy.IF_POSSIBLE);_
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TraceSegmentServiceClient.java#L63-L69
so this line 45 will be execute runtime
https://github.com/apache/skywalking/blob/bf639d3ec6d3cad994d6a5234ae8420fe86021d5/apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/buffer/ArrayBlockingQueueBuffer.java#L42-L55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial commented on issue #6045: ArrayBlockingQueueBuffer is activated unexpected in the IF_POSSIBLE mode
Posted by GitBox <gi...@apache.org>.
lijial commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-749059851
> Logically yes. If you want, feel free to send another pull request to fix after #6048 merged
OK, I would send another pull later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial commented on issue #6045: ArrayBlockingQueueBuffer is activated unexpected in the IF_POSSIBLE mode
Posted by GitBox <gi...@apache.org>.
lijial commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-749025991
> Also, note, the exception(NPE) wouldn't happen, as in SkyWalking, no one should put a NULL into the queue, right?
I thought there's something wrong in the constructor(DataCarrierTest:testProduce() Line 60 ) .
And also DataCarrierTest:testBlockingProduce() method
https://github.com/apache/skywalking/commit/09c0e8e32d643eb8a4189225925389ab0e483252#diff-552816423049ee3be17a365cfcdc999a9af8f27bac814bcdcfb310faab82aa01L50
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial edited a comment on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial edited a comment on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748932386
@wu-sheng Dear, In this pic below, as red box shows, so I still hold the doubt as topic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lijial commented on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
lijial commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748932386
In this pic above, as red box shows, so I still hold the doubt as topic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6045: Version 8.3.0 ArrayBlockingQueueBuffer class save() method not catch exception
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6045:
URL: https://github.com/apache/skywalking/issues/6045#issuecomment-748956598
Oh, this is a very serious bug we haven't detected for a very long time. Actually, the issue is, strategy determines the channel implementation. In the `if_possible`, should be `Buffer` rather than `ArrayBlockingQueueBuffer`.
So, the change should be **remove** `DataCarrier#setBufferStrategy` method, and require `BufferStrategy` in the constructor.
Are you willing to fix this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org