You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/07/25 19:40:02 UTC

[I] Get Clippy clean for Rust 1.80 and run it on CI [datafusion]

alamb opened a new issue, #11657:
URL: https://github.com/apache/datafusion/issues/11657

   ### Is your feature request related to a problem or challenge?
   
   A new Rust version was released that causes CI to fail -- see https://github.com/apache/datafusion/issues/11651
   
   @findepi made a PR to pin CI to use Rust 1.79 while we work out the clippy failures: https://github.com/apache/datafusion/pull/11655
   
   We should remove the wokaround and use the latest rust once we have sorted out clippy
   
   ### Describe the solution you'd like
   
   Remove the workaround file and use the latest rust again
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Get Clippy clean for Rust 1.80 and run it on CI [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #11657:
URL: https://github.com/apache/datafusion/issues/11657#issuecomment-2251303286

   I will handle this item (now that https://github.com/apache/datafusion/pull/11654 is merged)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Get Clippy clean for Rust 1.80 and run it on CI [datafusion]

Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead closed issue #11657: Get Clippy clean for Rust 1.80 and run it on CI
URL: https://github.com/apache/datafusion/issues/11657


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Get Clippy clean for Rust 1.80 and run it on CI [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #11657:
URL: https://github.com/apache/datafusion/issues/11657#issuecomment-2251270410

   Note  I believe @nrc has fixed some of these already in https://github.com/apache/datafusion/pull/11467, but we got stuck there on tests that only failed once we properly passed through hash_collisions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Get Clippy clean for Rust 1.80 and run it on CI [datafusion]

Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on issue #11657:
URL: https://github.com/apache/datafusion/issues/11657#issuecomment-2251277374

   https://github.com/apache/datafusion/pull/11654 includes https://github.com/apache/datafusion/pull/11467 and passes clippy 1.80 locally
   
   >  but we got stuck there on tests that only failed once we properly passed through hash_collisions
   
   outstanding action item


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Get Clippy clean for Rust 1.80 and run it on CI [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #11657:
URL: https://github.com/apache/datafusion/issues/11657#issuecomment-2251289029

   I am filing some tickets to track the new test failures


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Get Clippy clean for Rust 1.80 and run it on CI [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #11657:
URL: https://github.com/apache/datafusion/issues/11657#issuecomment-2251317642

   https://github.com/apache/datafusion/pull/11661 is up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org