You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/14 13:37:37 UTC
[GitHub] [nifi] UcanInfosec opened a new pull request, #6123: Update GCP SDK
UcanInfosec opened a new pull request, #6123:
URL: https://github.com/apache/nifi/pull/6123
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NiFi 10082](https://issues.apache.org/jira/projects/NIFI/issues/NIFI-10082)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/projects/NIFI/issues/NIFI-10082) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
Built accordingly and it worked. Accidentally cancelled workflow after it completed in my branch.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 8
- [x] JDK 11
- [X ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6123: NIFI-10082 Update GCP SDK
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6123:
URL: https://github.com/apache/nifi/pull/6123#issuecomment-1155331671
@UcanInfosec, here is one site that describes how to squash multiple commits using Git:
https://gitbetter.substack.com/p/how-to-squash-git-commits
Creating a new branch from your current fork also works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] UcanInfosec commented on pull request #6123: NIFI-10082 Update GCP SDK
Posted by GitBox <gi...@apache.org>.
UcanInfosec commented on PR #6123:
URL: https://github.com/apache/nifi/pull/6123#issuecomment-1155275365
@exceptionfactory apologies to have this run a 2nd time. Wasnt sure why this failed the 1st time when it passed on my fork. The only change that was made in the fork was this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] UcanInfosec commented on pull request #6123: NIFI-10082 Update GCP SDK
Posted by GitBox <gi...@apache.org>.
UcanInfosec commented on PR #6123:
URL: https://github.com/apache/nifi/pull/6123#issuecomment-1155295709
@exceptionfactory not exactly sure how to do that. But if I deleted the branch/fork, created a new fork, and reapplied the changes, would it fix the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6123: NIFI-10082 Update GCP SDK
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6123:
URL: https://github.com/apache/nifi/pull/6123#issuecomment-1155283863
> @exceptionfactory apologies to have this run a 2nd time. Wasnt sure why this failed the 1st time when it passed on my fork. The only change that was made in the fork was this change.
Thanks @UcanInfosec. Since this is a simple change, can you squash the current three commits and force-push an update to the branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org