You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "r4ntix (via GitHub)" <gi...@apache.org> on 2023/03/28 09:10:28 UTC
[GitHub] [arrow-ballista] r4ntix opened a new pull request, #727: Upgrade DataFusion to 21.0.0
r4ntix opened a new pull request, #727:
URL: https://github.com/apache/arrow-ballista/pull/727
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Upgrade DataFusion to 21.0.0
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing commented on pull request #727: Upgrade DataFusion to 21.0.0
Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing commented on PR #727:
URL: https://github.com/apache/arrow-ballista/pull/727#issuecomment-1493534533
Thanks @r4ntix. How about extracting the feature based store into a single method, like the following does
https://github.com/yahoNanJing/arrow-ballista/blob/84a98d73a164b655b80f4391611de4c499b27f73/ballista/core/src/utils.rs#L105-L179?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] r4ntix commented on pull request #727: Upgrade DataFusion to 21.0.0
Posted by "r4ntix (via GitHub)" <gi...@apache.org>.
r4ntix commented on PR #727:
URL: https://github.com/apache/arrow-ballista/pull/727#issuecomment-1493559786
> Thanks @r4ntix. How about extracting the feature based store into a single method, like the following does https://github.com/yahoNanJing/arrow-ballista/blob/84a98d73a164b655b80f4391611de4c499b27f73/ballista/core/src/utils.rs#L105-L179? Then we can separate the **_get_** and **_register_** logic.
@yahoNanJing thanks for the feedback. i will submit a new commit for it a little later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing merged pull request #727: Upgrade DataFusion to 21.0.0
Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing merged PR #727:
URL: https://github.com/apache/arrow-ballista/pull/727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org