[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #506: Add window frame constructs - alternative

[GitBox <gi...@apache.org>]

Jimexist commented on a change in pull request #506:
URL: https://github.com/apache/arrow-datafusion/pull/506#discussion_r646119730



##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1283,8 +1284,23 @@ impl fmt::Debug for Expr {
             Expr::ScalarUDF { fun, ref args, .. } => {
                 fmt_function(f, &fun.name, false, args)
             }
-            Expr::WindowFunction { fun, ref args, .. } => {
-                fmt_function(f, &fun.to_string(), false, args)
+            Expr::WindowFunction {
+                fun,
+                ref args,
+                window_frame,
+                ..
+            } => {
+                fmt_function(f, &fun.to_string(), false, args)?;
+                if let Some(window_frame) = window_frame {
+                    write!(
+                        f,
+                        " {} BETWEEN {} AND {}",

Review comment:
       It's intentional because the space is a separator from function name




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org