You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by dd...@apache.org on 2012/06/26 20:27:57 UTC

Re: Review Request: Bug fix for openEE implementation in open-views feature and change the scrolling settings in container.url feature

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1505/
-----------------------------------------------------------

(Updated June 26, 2012, 6:27 p.m.)


Review request for shindig and Ryan Baxter.


Description
-------

1. Current openEE implementation in open-views feature cannot handle URL data model
2. The scroll bar is always visible when using the navigateUrl API, prefer to change the scrolling settings from "yes" to "auto".

Link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1573


This addresses bug SHINDIG-1573.
    https://issues.apache.org/jira/browse/SHINDIG-1573


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1157881 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_holder.js 1157881 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1157948 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_holder_test.js 1157881 
  http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js 1157881 

Diff: https://reviews.apache.org/r/1505/diff/


Testing
-------

Test done on embedded experience sample container with sample gadget, passed jsUnit test.  


Thanks,

Jason Chiang