[GitHub] [incubator-superset] villebro commented on issue #9366: deprecate groupby controls in query_obj

[GitBox <gi...@apache.org>]

villebro commented on issue #9366: deprecate groupby controls in query_obj
URL: https://github.com/apache/incubator-superset/pull/9366#issuecomment-606874266
 
 
   > @villebro you mentioned,
   > 
   > > To simplify the query object and viz controls, it makes sense to group these together and always perform grouping if at least one metric is present.
   > 
   > Why must you perform a grouping in only metric is present?
   
   I was actually thinking about adding a `force_groupby`, but decided against it at this point as there didn't seem to be any visualizations that were depending on this functionality currently. I anticipate we will probably also need to introduce a `distinct` flag at some point, too, but for now I would prefer to keep these PRs as contained as possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org