You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/04 02:54:00 UTC

[I] [BUG] Last Will & Testament entirely unimplemented — will never published on ungraceful disconnect [shenyu]

Aias00 opened a new issue, #6852:
URL: https://github.com/apache/shenyu/issues/6852

   ## Description
   The CONNECT payload's will fields are dropped on the floor; nothing stores a will (module-wide grep for `willMessage|willTopic|cleanSession|hasWill` returns zero hits), `Disconnect` never publishes one, and there is no `channelInactive`/ungraceful-close hook that would fire a will on a dropped connection.
   
   ## Location
   - `shenyu-protocol/shenyu-protocol-mqtt/src/main/java/org/apache/shenyu/protocol/mqtt/Connect.java` (connect method never reads will fields)
   - `shenyu-protocol/shenyu-protocol-mqtt/src/main/java/org/apache/shenyu/protocol/mqtt/Disconnect.java:39` (`// todo Last words`)
   - `shenyu-protocol/shenyu-protocol-mqtt/src/main/java/org/apache/shenyu/protocol/mqtt/MqttTransportHandler.java:42-44` (empty `operationComplete`)
   
   ## Impact
   Clients that publish a Last Will during CONNECT never have it delivered on an ungraceful disconnect, defeating a core reliability feature of MQTT.
   
   ## Suggested fix
   Parse and store will fields in `MqttContext`/session on CONNECT; on `channelInactive` for a non-clean session with a will, publish the will message with its configured QoS/retain; clear the will on graceful DISCONNECT.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [BUG] Last Will & Testament entirely unimplemented — will never published on ungraceful disconnect [shenyu]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6852:
URL: https://github.com/apache/shenyu/issues/6852#issuecomment-5174060340

   👋 Hello @yuluo-yx
   
   A new issue has been opened by @Aias00:
   - **Title**: [BUG] Last Will & Testament entirely unimplemented — will never published on ungraceful disconnect
   - **Link**: https://github.com/apache/shenyu/issues/6852
   
   Please review when you have time. Thank you! 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [BUG] Last Will & Testament entirely unimplemented — will never published on ungraceful disconnect [shenyu]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #6852: [BUG] Last Will & Testament entirely unimplemented — will never published on ungraceful disconnect
URL: https://github.com/apache/shenyu/issues/6852


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [BUG] Last Will & Testament entirely unimplemented — will never published on ungraceful disconnect [shenyu]

Posted by "wy471x (via GitHub)" <gi...@apache.org>.
wy471x commented on issue #6852:
URL: https://github.com/apache/shenyu/issues/6852#issuecomment-5178687042

   /assign


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org