[GitHub] metron pull request #1211: METRON-1792 Simplify Profile Definitions in Integ...

[nickwallen <gi...@git.apache.org>]

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1211#discussion_r223501784
  
    --- Diff: metron-analytics/metron-profiler-storm/src/test/java/org/apache/metron/profiler/storm/integration/ConfigUploadComponent.java ---
    @@ -86,11 +90,17 @@ private void upload() throws Exception {
        * @param client The zookeeper client.
        */
       private void uploadProfilerConfig(CuratorFramework client) throws Exception {
    -    if (profilerConfiguration != null) {
    -      byte[] globalConfig = readProfilerConfigFromFile(profilerConfiguration);
    -      if (globalConfig.length > 0) {
    -        writeProfilerConfigToZookeeper(readProfilerConfigFromFile(profilerConfiguration), client);
    -      }
    +    byte[] configBytes = null;
    +
    +    if (profilerConfigurationPath != null) {
    +      configBytes = readProfilerConfigFromFile(profilerConfigurationPath);
    +
    +    } else if(profilerConfig != null) {
    --- End diff --
    
    I need the upload to happen based on either a path to a file or a String that was passed in.


---