You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/05/08 09:22:50 UTC
Re: Review Request: FLUME-2037. testDataFilesRequiredByBackupNotDeleted is
flakey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11002/
-----------------------------------------------------------
(Updated May 8, 2013, 7:22 a.m.)
Review request for Flume.
Changes
-------
Change bug #
Summary (updated)
-----------------
FLUME-2037. testDataFilesRequiredByBackupNotDeleted is flakey
Description
-------
Updated the test to make it more tolerant but still correct.
This addresses bug FLUME-2037.
https://issues.apache.org/jira/browse/FLUME-2037
Diffs
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java e61437d
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java dc6fc45
Diff: https://reviews.apache.org/r/11002/diff/
Testing
-------
Ran the test - works fine.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-2037. testDataFilesRequiredByBackupNotDeleted is
flakey
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11002/#review21024
-----------------------------------------------------------
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java
<https://reviews.apache.org/r/11002/#comment43510>
lastModified() does return ms but only a seconds granularity. Could this lead to flaky tests?
- Brock Noland
On May 8, 2013, 7:22 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11002/
> -----------------------------------------------------------
>
> (Updated May 8, 2013, 7:22 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Updated the test to make it more tolerant but still correct.
>
>
> This addresses bug FLUME-2037.
> https://issues.apache.org/jira/browse/FLUME-2037
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java e61437d
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java dc6fc45
>
> Diff: https://reviews.apache.org/r/11002/diff/
>
>
> Testing
> -------
>
> Ran the test - works fine.
>
>
> Thanks,
>
> Hari Shreedharan
>
>