[jira] [Comment Edited] (ZOOKEEPER-1870) flakey test in StandaloneDisabledTest.startSingleServerTest

["Flavio Junqueira (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950173#comment-13950173 ] 

Flavio Junqueira edited comment on ZOOKEEPER-1870 at 3/27/14 11:59 PM:
-----------------------------------------------------------------------

This looks good to me. I was just wondering if there is a concrete reason for setting proposedLeader to -1 when we shut it down. Is it necessary or just good to have?

I was also wondering if we should check this into the 3.4 branch as well as trunk.


was (Author: fpj):
This looks good to me. I was just wondering if there is a concrete reason for setting proposedLeader to -1 when we shut it down. Is it necessary or just good to have?

> flakey test in StandaloneDisabledTest.startSingleServerTest
> -----------------------------------------------------------
>
>                 Key: ZOOKEEPER-1870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1870
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 3.5.0
>            Reporter: Patrick Hunt
>            Assignee: Helen Hastings
>            Priority: Blocker
>         Attachments: ZOOKEEPER-1870.patch, ZOOKEEPER-1870.patch, test.log
>
>
> I'm seeing lots of the following failure. Seems like a flakey test (passes every so often).
> {noformat}
> junit.framework.AssertionFailedError: client could not connect to reestablished quorum: giving up after 30+ seconds.
> 	at org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:143)
> 	at org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest(StandaloneDisabledTest.java:75)
> 	at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {noformat}
> I've found 3 problems:
> 1. QuorumCnxManager.Listener.run() leaks the socket depending on when the shutdown flag gets set.
> 2. QuorumCnxManager.halt() doesn't wait for the listener to terminate.
> 3. QuorumPeer.shuttingDownLE flag doesn't get reset when restarting the leader election.



--
This message was sent by Atlassian JIRA
(v6.2#6252)