You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shiro.apache.org by GitBox <gi...@apache.org> on 2020/04/10 14:07:19 UTC

[GitHub] [shiro] bdemers commented on a change in pull request #206: Deprecate unsecure XMLSerializer

bdemers commented on a change in pull request #206: Deprecate unsecure XMLSerializer
URL: https://github.com/apache/shiro/pull/206#discussion_r406773094
 
 

 ##########
 File path: lang/src/main/java/org/apache/shiro/io/XmlSerializer.java
 ##########
 @@ -34,7 +34,9 @@
  * JavaBeans compatible!
  * 
  * @since 0.9
+ * @deprecated This class should not be used because of unsecure XMLEncoder/XMLDecoder usage.
 
 Review comment:
   ```suggestion
    * @deprecated This class should not be used directly because of unsecure XMLEncoder/XMLDecoder usage.
   ```
   
   You might want to say "used directly" 🤔 
   if/when this is wrapped in encryption most of the risk is removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services