[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #9186: [Fix-9065] [master] when task submit failed, remove from queue and add state event to thread

[GitBox <gi...@apache.org>]

caishunfeng commented on a change in pull request #9186:
URL: https://github.com/apache/dolphinscheduler/pull/9186#discussion_r839574906



##########
File path: dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -1782,6 +1784,11 @@ private void submitStandByTask() {
                     TaskInstance taskInstance = submitTaskExec(task);
                     if (taskInstance == null) {
                         this.taskFailedSubmit = true;
+                        // Remove and add to complete map and error map
+                        removeTaskFromStandbyList(task);

Review comment:
       It's better to retry if task submit fail, but not remove and mark it error and complete. What do you think?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org