You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/07 20:36:30 UTC

[PR] test(ai): pin the group update handler upsert and stamp contracts [rocketmq-dashboard]

zjncs opened a new pull request, #5689:
URL: https://github.com/apache/rocketmq-dashboard/pull/5689

   ### Problem
   
   `ConsumerGroupUpdateToolHandler` — the `rmq.group.update` mutation tool — had **no test**.
   
   ### Change
   
   Add `ConsumerGroupUpdateToolHandlerTest` with seven tests:
   
   | Contract | Pinned behaviour |
   | --- | --- |
   | upsert | execute on an **absent** group takes the create path; execute on an existing group takes the update path with a **sparse merge** — a one-field input (`retryMaxTimes`) updates that field and leaves subscription mode, consume type, subscription data type, delivery order type and name untouched (captured on the argument handed to `updateConsumerGroup`) |
   | instance stamp | the persisted row **carries the context's instance** even on the create path with a null input instanceId — without the stamp the row would be written without an owner |
   | preview | an absent group has no before state; an **identical** configuration warns; a sparse input merges onto the current state with untouched fields keeping the **current** values in the after state, not defaults |
   | identity | the tool name and input type round-trip |
   
   ### Verification
   
   - New tests: **7/7 green** against unmodified code.
   - Discriminating mutations on the handler (build result verified): the absent-group create path dropped (**red**); the context-instance stamp dropped (**red**); the identical-config warning dropped (**red**); the execute merge replaced with the input-only configuration (**red**).
   - Restored: 7/7 green. No product code changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(ai): pin the group update handler upsert and stamp contracts [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] commented on PR #5689:
URL: https://github.com/apache/rocketmq-dashboard/pull/5689#issuecomment-6810408209

   This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(ai): pin the group update handler upsert and stamp contracts [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] closed pull request #5689: test(ai): pin the group update handler upsert and stamp contracts
URL: https://github.com/apache/rocketmq-dashboard/pull/5689


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org