[jira] Commented: (TILES-516) JSP exceptions are hidden by Tiles making debugging difficult

["Clayton Rabenda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TILES-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918634#action_12918634 ] 

Clayton Rabenda commented on TILES-516:
---------------------------------------

Sorry Antonio,
I will try to get back to this in the near future. My bug report was based on using 2.2.0 but I also took a look at the code for 2.2.2 and was really basing this bug report off of that. I'm basically just trying to argue that there should be some logging before all the throws in the render methods in BasicTilesContainer.

I'm currently at the end of a project and trying to meet a deadline and also am moving to Zurich from the US on Saturday so very much starved for free time at the moment. Once I am settled down I will give 2.2.2 a try and let you know what I find.

If you want to reproduce this, you can just use any malformed xml in a jspx as a template and observe that the original exception will not be available in the log... It may also simply be that I have something misconfigured.

> JSP exceptions are hidden by Tiles making debugging difficult
> -------------------------------------------------------------
>
>                 Key: TILES-516
>                 URL: https://issues.apache.org/jira/browse/TILES-516
>             Project: Tiles
>          Issue Type: Bug
>            Reporter: Clayton Rabenda
>
> When using tiles:insertDefinition, any exceptions thrown by the jsp renderer are being hidden from the logs by TilesContainer.
> Based upon apache's logging best practices(http://commons.apache.org/logging/guide.html), I believe it would be best if exceptions caught in TilesContainer's render methods were logged before being rethrown.
> "External Boundaries - Expected Exceptions. This classification includes exceptions such as FileNotFoundException that cross API/SPI boundaries, and are exposed to the user of a component/toolkit. These are listed in the 'throws' clause of a method signature.
> Appropriate handling of these exceptions depends upon the type of code you are developing. API's for utility functions and tools should log these at the debug level, if they are caught at all by internal code.
> For higher level frameworks and middleware components, these exceptions should be caught immediatly prior to crossing the API/SPI interface back to user code-space, logged with full stack trace at info level, and rethrown. The assures that the log contains a record of the root cause for future analysis in the event that the exception is not caught and resolved as expected by the user's code. "

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.