You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "breautek (via GitHub)" <gi...@apache.org> on 2026/06/17 18:53:02 UTC
[PR] refactor!: Replace p libs with native JS APIs [cordova-plugman]
breautek opened a new pull request, #197:
URL: https://github.com/apache/cordova-plugman/pull/197
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
CLI
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Modernizing the codebase to remove third-party dependencies
### Description
<!-- Describe your changes in detail -->
- Replaced p libs with native promises
- Use async/await keywords and removed temporarily placed wrapper code
- Added commands test spec with a mocked plugman (testing the actual plugman cordova-lib API is cordova-lib's job).
Marked as a breaking change due to the introduction of async syntax. Current engines should be already a satisfied based on these new requirements.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Ran npm test
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] refactor!: Replace p libs with native JS APIs [cordova-plugman]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #197:
URL: https://github.com/apache/cordova-plugman/pull/197#issuecomment-4734166219
## [Codecov](https://app.codecov.io/gh/apache/cordova-plugman/pull/197?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.92%. Comparing base ([`5ba1d3a`](https://app.codecov.io/gh/apache/cordova-plugman/commit/5ba1d3ad050b2955034ef8f0462e7b000ce955b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`62d7e6a`](https://app.codecov.io/gh/apache/cordova-plugman/commit/62d7e6ad1cadb7968b1ae18e8b01dfd140cbd7c9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #197 +/- ##
===========================================
+ Coverage 59.15% 82.92% +23.77%
===========================================
Files 5 5
Lines 71 82 +11
===========================================
+ Hits 42 68 +26
+ Misses 29 14 -15
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cordova-plugman/pull/197?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] refactor!: Replace p libs with native JS APIs [cordova-plugman]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #197:
URL: https://github.com/apache/cordova-plugman/pull/197#issuecomment-4742203664
> If you can figure out a way to avoid using rewire, that would be even better. Since there are only two test files, I was hoping we could eventually drop rewire and Jasmine in favor of Node's built-in test framework, but that could also be revisited in a separate PR.
Probably could be done but I'll try it in a separate PR and I'll create an issue for myself to serve as a reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] refactor!: Replace p libs with native JS APIs [cordova-plugman]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek merged PR #197:
URL: https://github.com/apache/cordova-plugman/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org