You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-issues@hadoop.apache.org by "Kihwal Lee (JIRA)" <ji...@apache.org> on 2014/06/30 20:29:26 UTC

[jira] [Commented] (HDFS-6415) Missing null check in FSImageSerialization#writePermissionStatus()

    [ https://issues.apache.org/jira/browse/HDFS-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047944#comment-14047944 ] 

Kihwal Lee commented on HDFS-6415:
----------------------------------

I don't think we want to do anything special here. If it ever happens for some reason, it should fail. I think it already does with NPE.

> Missing null check in FSImageSerialization#writePermissionStatus()
> ------------------------------------------------------------------
>
>                 Key: HDFS-6415
>                 URL: https://issues.apache.org/jira/browse/HDFS-6415
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Ted Yu
>            Assignee: Chen He
>            Priority: Minor
>         Attachments: HDFS-6415.patch
>
>
> {code}
>     PermissionStatus.write(out, inode.getUserName(), inode.getGroupName(), p);
> {code}
> getUserName() / getGroupName() may return null.
> null check should be added for these two calls.



--
This message was sent by Atlassian JIRA
(v6.2#6252)