You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/16 04:13:59 UTC
[GitHub] [dolphinscheduler] ruanwenjun opened a new issue, #10473: [Discuss][Master] Refractor the WorkflowExecuteRunnable
ruanwenjun opened a new issue, #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Right now, we use `WorkflowExecuteRunnable` to handle the workflow event and task event, this make this class be huge if we need to add a new event, we need to modify this class, it will be hard to add new event.
I have an idea, we can split the workflow event and task event into different event queue, and use different event handler to deal with different event, when we handle a target event, we may need to generate new workflow/task event.
<img width="1598" alt="image" src="https://user-images.githubusercontent.com/22415594/173989139-6b5f68db-ab59-4330-8368-38fe9958d290.png">
The advantage is that, we can split the event handle logic, and when we need to add a new event type, we only need to add a new event handler.
There is some problem need to deal, the task/workflow's events may need to have order, we may still need to create event queue for each workflow, or use state machine to implement the order.
This is just an open discussion, welcome to discuss.
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss][Master] Refractor the WorkflowExecuteRunnable [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473#issuecomment-2000752732
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10473: [Discuss][Master] Refractor the WorkflowExecuteRunnable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473#issuecomment-1210016418
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss][Master] Refractor the WorkflowExecuteRunnable [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on issue #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473#issuecomment-1869891913
> I think we also need to redesign the state machine for task instance and workflow instance. Otherwise the logic will be confusing and easy to result in bugs when state handlers process those events.
Yes, I will give a pic design, and poc code, if I am free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10473: [Discuss][Master] Refractor the WorkflowExecuteRunnable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473#issuecomment-1157212126
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss][Master] Refractor the WorkflowExecuteRunnable [dolphinscheduler]
Posted by "EricGao888 (via GitHub)" <gi...@apache.org>.
EricGao888 commented on issue #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473#issuecomment-1869884924
No stale
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss][Master] Refractor the WorkflowExecuteRunnable [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #10473: [Discuss][Master] Refractor the WorkflowExecuteRunnable
URL: https://github.com/apache/dolphinscheduler/issues/10473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #10473: [Discuss][Master] Refractor the WorkflowExecuteRunnable
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473#issuecomment-1179748298
We can use a single WorkflowEventQueue, and for each TaskInstance we can create a TaskEventQueue, all state changed are at the event handler. we can control the event handle at event handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss][Master] Refractor the WorkflowExecuteRunnable [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473#issuecomment-1843928880
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss][Master] Refractor the WorkflowExecuteRunnable [dolphinscheduler]
Posted by "EricGao888 (via GitHub)" <gi...@apache.org>.
EricGao888 commented on issue #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473#issuecomment-1869885853
I think we also need to redesign the state machine for task instance and workflow instance. Otherwise the logic will be confusing and easy to result in bugs when state handlers process those events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss][Master] Refractor the WorkflowExecuteRunnable [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473#issuecomment-1869837655
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss][Master] Refractor the WorkflowExecuteRunnable [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #10473: [Discuss][Master] Refractor the WorkflowExecuteRunnable
URL: https://github.com/apache/dolphinscheduler/issues/10473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss][Master] Refractor the WorkflowExecuteRunnable [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473#issuecomment-1942893038
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Discuss][Master] Refractor the WorkflowExecuteRunnable [dolphinscheduler]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #10473:
URL: https://github.com/apache/dolphinscheduler/issues/10473#issuecomment-2016642358
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org