You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2018/03/21 06:39:11 UTC

svn commit: r1827387 - in /pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature: ShowSignature.java validation/CertInformationHelper.java

Author: msahyoun
Date: Wed Mar 21 06:39:11 2018
New Revision: 1827387

URL: http://svn.apache.org/viewvc?rev=1827387&view=rev
Log:
PDFBOX-4118: log debug exception so information is cpatured when returning false

Modified:
    pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/ShowSignature.java
    pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationHelper.java

Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/ShowSignature.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/ShowSignature.java?rev=1827387&r1=1827386&r2=1827387&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/ShowSignature.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/ShowSignature.java Wed Mar 21 06:39:11 2018
@@ -32,6 +32,8 @@ import java.security.cert.CertificateFac
 import java.security.cert.X509Certificate;
 import java.text.SimpleDateFormat;
 import java.util.Collection;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 import org.apache.pdfbox.cos.COSArray;
 import org.apache.pdfbox.cos.COSBase;
@@ -67,6 +69,8 @@ import org.bouncycastle.util.StoreExcept
  */
 public final class ShowSignature
 {
+    private static final Log LOG = LogFactory.getLog(ShowSignature.class);
+
     private final SimpleDateFormat sdf = new SimpleDateFormat("dd.MM.yyyy HH:mm:ss");
 
     private ShowSignature()
@@ -355,6 +359,7 @@ public final class ShowSignature
         }
         catch (SignatureException | InvalidKeyException sigEx)
         {
+            LOG.debug("Couldn't get signature information - returning false", sigEx);
             return false;
         }
     }

Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationHelper.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationHelper.java?rev=1827387&r1=1827386&r2=1827387&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationHelper.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationHelper.java Wed Mar 21 06:39:11 2018
@@ -109,6 +109,7 @@ public class CertInformationHelper
                 }
                 catch (SignatureException se)
                 {
+                    LOG.debug("Couldn't get signature information - returning false", se);
                     return false;
                 }
             }