You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/08/26 16:21:38 UTC

[GitHub] [phoenix-connectors] stoty commented on pull request #26: PHOENIX-6076 Refactor Phoenix Hive Connectors introduced by PHOENIX-6057

stoty commented on pull request #26:
URL: https://github.com/apache/phoenix-connectors/pull/26#issuecomment-680982766


   The java part basically looks good.
   
   My problem is that we are building the code in the -common modules, when there is no reason to do that. (This applies both to hive and the rest of the connectors)
   
   The -common modules should really just define the common dependencies, and have compiling/testing disabled.
   
   You can base this on how it's done in Tephra.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org