[GitHub] [dubbo] wxbty commented on a diff in pull request #12725: BugFix/FixIsAvailableTimeout is available timeout

["wxbty (via GitHub)" <gi...@apache.org>]

wxbty commented on code in PR #12725:
URL: https://github.com/apache/dubbo/pull/12725#discussion_r1264599175


##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/ServiceDiscovery.java:
##########
@@ -94,6 +95,13 @@ default long getDelay() {
         return getUrl().getParameter(REGISTRY_DELAY_NOTIFICATION_KEY, 5000);
     }
 
+    /**
+     * Get services is the default way for service discovery to be available
+     */
+    default boolean isAvailable() {
+        return CollectionUtils.isNotEmpty(getServices());

Review Comment:
   This is a new method, it seems that it just replaces the empty judgment of getServices().



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org