You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/16 12:33:35 UTC

[GitHub] [mynewt-core] andrzej-kaczmarek commented on issue #2237: [WIP DNM] Added bsp and mcu packages for dialog_da14695-dk-usb

andrzej-kaczmarek commented on issue #2237: [WIP DNM] Added bsp and mcu packages for dialog_da14695-dk-usb
URL: https://github.com/apache/mynewt-core/pull/2237#issuecomment-599511151
 
 
   Overall this looks good, although I'd consider moving scripts to some common package [1] since there's quite a lot of code there which will soon go out of sync between BSPs. also common syscfg `BOOT_*` defs could be included by `$import` in such case. I'd like to know what other think about this way of reusing code in BSPs since we do do this for other vendors.
   
   [1] I see two reasonable ways of doing this: simply create `hw/bsp/dialog_common` package or move all dialog code to `hw/bsp/dialog`, e.g. `hw/bsp/dialog/common`, `hw/bsp/dialog/da1469x-dk-pro` etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services