You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/07/20 16:11:19 UTC
[GitHub] flink pull request #2273: [FLINK-4238] Only allow/require query for Tuple St...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/2273
[FLINK-4238] Only allow/require query for Tuple Stream in CassandraSink
R: @zentol for review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink cassandra-tuple-query
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2273
----
commit 89021cbc85d36c458b5e0977dd052809072535d7
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2016-07-20T16:10:11Z
[FLINK-4238] Only allow/require query for Tuple Stream in CassandraSink
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2273: [FLINK-4238] Only allow/require query for Tuple Stream in...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2273
Since we now have separate branches for both sink types it may be worthwhile to move these checks completely into the respective `CassandraXXXSinkBuilder` classes. Otherwise, +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2273: [FLINK-4238] Only allow/require query for Tuple Stream in...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2273
Thanks for review! I moved the checks to the specific builders.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2273: [FLINK-4238] Only allow/require query for Tuple St...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/2273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---