You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ro...@apache.org on 2022/12/13 16:46:12 UTC
[pinot] branch master updated: Fix the executor config wiring issue for Multi-stage engine (#9978)
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 0338d5d681 Fix the executor config wiring issue for Multi-stage engine (#9978)
0338d5d681 is described below
commit 0338d5d6817658b4bb1a73c0d27cf0752ead45b1
Author: Seunghyun Lee <se...@startree.ai>
AuthorDate: Tue Dec 13 08:46:03 2022 -0800
Fix the executor config wiring issue for Multi-stage engine (#9978)
* Fix the executor config wiring issue for Multi-stage engine
Multi-stage engine initialization code has a bug when passing the
pinot execution config. This makes the executor config not correctly
wired. This PR fixes the issue.
Co-authored-by: Rong Rong <ro...@startree.ai>
---
.../src/main/java/org/apache/pinot/query/runtime/QueryRunner.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java b/pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java
index 54e733e27b..65dfb4056b 100644
--- a/pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java
+++ b/pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java
@@ -73,6 +73,8 @@ import org.slf4j.LoggerFactory;
*/
public class QueryRunner {
private static final Logger LOGGER = LoggerFactory.getLogger(QueryRunner.class);
+ private static final String PINOT_V1_SERVER_QUERY_CONFIG_PREFIX = "pinot.server.query.executor";
+
// This is a temporary before merging the 2 type of executor.
private ServerQueryExecutorV1Impl _serverExecutor;
private HelixManager _helixManager;
@@ -100,7 +102,7 @@ public class QueryRunner {
new NamedThreadFactory("query_worker_on_" + _port + "_port")));
_mailboxService = MultiplexingMailboxService.newInstance(_hostname, _port, config, _scheduler::onDataAvailable);
_serverExecutor = new ServerQueryExecutorV1Impl();
- _serverExecutor.init(config, instanceDataManager, serverMetrics);
+ _serverExecutor.init(config.subset(PINOT_V1_SERVER_QUERY_CONFIG_PREFIX), instanceDataManager, serverMetrics);
} catch (Exception e) {
throw new RuntimeException(e);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org