You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/01/14 13:17:08 UTC

[GitHub] [activemq-artemis] gaohoward opened a new pull request #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase

gaohoward opened a new pull request #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase
URL: https://github.com/apache/activemq-artemis/pull/2938
 
 
   If you kill the server without invoking a normal shutdown, tmp
   web files are not cleaned out.  This leaves old webapp folders
   lingering until a normal shutdown.
   
   In a failover test environment that repeatedly kills the server,
   this causes disk space usage issues.
   
   The fix is to add a cleanup method before the web server starts.
   It searches the tmp web dir if there is any leftover files/dirs
   and delete them if any.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] clebertsuconic commented on issue #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase

Posted by GitBox <gi...@apache.org>.

clebertsuconic commented on issue #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase
URL: https://github.com/apache/activemq-artemis/pull/2938#issuecomment-576839126
 
 
   There's a binary as part of this PR? is that a mistake?
   
   if not? you shoudln't commit binaries without their source code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] gaohoward commented on issue #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase

Posted by GitBox <gi...@apache.org>.

gaohoward commented on issue #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase
URL: https://github.com/apache/activemq-artemis/pull/2938#issuecomment-576983368
 
 
   I'll remove the binary war (copied from artemis-hawtio) and add a new war for the test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] jbertram commented on issue #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase

Posted by GitBox <gi...@apache.org>.

jbertram commented on issue #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase
URL: https://github.com/apache/activemq-artemis/pull/2938#issuecomment-589697705
 
 
   @clebertsuconic, can you take a look at @gaohoward's update?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] gaohoward commented on a change in pull request #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase

Posted by GitBox <gi...@apache.org>.

gaohoward commented on a change in pull request #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase
URL: https://github.com/apache/activemq-artemis/pull/2938#discussion_r369324880
 
 

 ##########
 File path: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
 ##########
 @@ -226,6 +227,7 @@ public void start() throws Exception {
       if (isStarted()) {
          return;
       }
+      cleanupTemporaryFilesIfAnyBeforeStart();
 
 Review comment:
   It eventually calls WebTmpCleaner but before that we need to figure out where the tmp dir is. (because before the web server start there is no tmpdir in each web context. The tmpdir only
   exists in the web context after the webapp (war) is deployed). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase

Posted by GitBox <gi...@apache.org>.

clebertsuconic commented on a change in pull request #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase
URL: https://github.com/apache/activemq-artemis/pull/2938#discussion_r369195301
 
 

 ##########
 File path: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
 ##########
 @@ -226,6 +227,7 @@ public void start() throws Exception {
       if (isStarted()) {
          return;
       }
+      cleanupTemporaryFilesIfAnyBeforeStart();
 
 Review comment:
   Can you just rename this to cleanupTmp(); ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase

Posted by GitBox <gi...@apache.org>.

clebertsuconic commented on a change in pull request #2938: ARTEMIS-2596 (kill -9) AMQ causes tmp web dir space usage to increase
URL: https://github.com/apache/activemq-artemis/pull/2938#discussion_r369196674
 
 

 ##########
 File path: artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
 ##########
 @@ -226,6 +227,7 @@ public void start() throws Exception {
       if (isStarted()) {
          return;
       }
+      cleanupTemporaryFilesIfAnyBeforeStart();
 
 Review comment:
   I don't understand one thing.. can't you reuse the WebTmpCleaner here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services