You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/03 19:52:09 UTC
[GitHub] [beam] kerrydc opened a new pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
kerrydc opened a new pull request #17005:
URL: https://github.com/apache/beam/pull/17005
**Please** add a meaningful description for your change here
Adds experimental Typescript Beam SDK
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kerrydc edited a comment on pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
Posted by GitBox <gi...@apache.org>.
kerrydc edited a comment on pull request #17005:
URL: https://github.com/apache/beam/pull/17005#issuecomment-1058428316
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles closed pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
Posted by GitBox <gi...@apache.org>.
kennknowles closed pull request #17005:
URL: https://github.com/apache/beam/pull/17005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kerrydc closed pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
Posted by GitBox <gi...@apache.org>.
kerrydc closed pull request #17005:
URL: https://github.com/apache/beam/pull/17005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kerrydc commented on pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
Posted by GitBox <gi...@apache.org>.
kerrydc commented on pull request #17005:
URL: https://github.com/apache/beam/pull/17005#issuecomment-1071208683
Closing in order to open a new PR with full commit history. I will also address Kenn and Danny's comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kerrydc edited a comment on pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
Posted by GitBox <gi...@apache.org>.
kerrydc edited a comment on pull request #17005:
URL: https://github.com/apache/beam/pull/17005#issuecomment-1058428316
R: @pabloem @robertwb @jrmccluskey @kennknowles @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a change in pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
Posted by GitBox <gi...@apache.org>.
damccorm commented on a change in pull request #17005:
URL: https://github.com/apache/beam/pull/17005#discussion_r819037472
##########
File path: sdks/typescript/README.md
##########
@@ -0,0 +1,191 @@
+# Typescript Beam SDK
Review comment:
```suggestion
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
# Typescript Beam SDK
```
##########
File path: sdks/typescript/src/apache_beam/proto/README.md
##########
@@ -0,0 +1,5 @@
+Generated typescript apache beam protos.
Review comment:
```suggestion
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Generated typescript apache beam protos.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #17005:
URL: https://github.com/apache/beam/pull/17005#issuecomment-1060872641
Heck, we could even add the proto-generated code to `master` without completing the review here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kerrydc commented on pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
Posted by GitBox <gi...@apache.org>.
kerrydc commented on pull request #17005:
URL: https://github.com/apache/beam/pull/17005#issuecomment-1071208683
Closing in order to open a new PR with full commit history. I will also address Kenn and Danny's comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kerrydc closed pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
Posted by GitBox <gi...@apache.org>.
kerrydc closed pull request #17005:
URL: https://github.com/apache/beam/pull/17005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #17005:
URL: https://github.com/apache/beam/pull/17005#issuecomment-1060872265
Request: put the proto generation in a separate commit so it is easy to browse the human-written code in isolation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kerrydc commented on pull request #17005: [BEAM-1754] Adds experimental Typescript Beam SDK
Posted by GitBox <gi...@apache.org>.
kerrydc commented on pull request #17005:
URL: https://github.com/apache/beam/pull/17005#issuecomment-1058428316
R: @robertwb @pabloem @jrmccluskey @kennknowles @damccorm
Please use this sheet to track whom will reviewed what:
https://docs.google.com/spreadsheets/d/16nqMaBIIyM3s0wq0eS10e-eqktuS8HYpCRkRDHmAMf8/edit?resourcekey=0-XSSaWA1KGji4qziOQyMiBg#gid=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org