build/9854: make install

[Aaron Namba <na...@cs.hmc.edu>]

>Number:         9854
>Category:       build
>Synopsis:       make install
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    apache
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Sun Feb 17 23:40:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     namba@cs.hmc.edu
>Release:        1.3.23
>Organization:
apache
>Environment:
Not applicable.
>Description:
>     -@if [ -d $(TOP)/htdocs/manual ]; then \
I am not exactly sure what caused the problem, but during the 'make install', in the section of code below, both $root and $manualdir became null, so a lot of files were installed to // (i.e., /). Also, the installer began chmod'ing EVERYTHING on the system to 755, which was extremely undesirable.

             echo "Copying tree $(TOP)/htdocs/manual -> $(root)/$(manualdir)/"; \
             (cd $(TOP)/htdocs/manual/ && $(TAR) $(TAROPT) - *) |\
             (cd $(root)$(manualdir)/ && $(TAR) -xf -); \
             find $(root)$(manualdir)/ -type d -exec chmod a+rx {} \; ; \
             find $(root)$(manualdir)/ -type f -print | xargs chmod a+r ; \
     fi
>How-To-Repeat:
I do not know how to repeat the problem, since the second install (performed very cautiously after doing a make -n) went fine.
>Fix:
I would STRONGLY suggest checking for the condition where $root and $manualdir are both "" and aborting the install, since the user is NEVER going to want all their directories and files chmod'ed to 755. I don't know how it even happened, but it did, and the resulting mess was extremely difficult to clean up.
>Release-Note:
>Audit-Trail:
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <ap...@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]