You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Vishal Suvagia via Review Board <no...@reviews.apache.org> on 2021/05/18 20:13:03 UTC

Review Request 73360: RANGER-3287 : Implement best practices for logging.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73360/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3287
    https://issues.apache.org/jira/browse/RANGER-3287


Repository: ranger


Description
-------

Implement best practices for logging


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java fb892d5c1c3ea6a2b8b74db4d09a886cf1363187 


Diff: https://reviews.apache.org/r/73360/diff/1/


Testing
-------

Validated changes locally.


Thanks,

Vishal Suvagia

Re: Review Request 73360: RANGER-3287 : Implement best practices for logging.

Posted by Abhay Kulkarni <ak...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73360/#review223016
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On May 20, 2021, 12:15 p.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73360/
> -----------------------------------------------------------
> 
> (Updated May 20, 2021, 12:15 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3287
>     https://issues.apache.org/jira/browse/RANGER-3287
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Implement best practices for logging
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java fb892d5c1c3ea6a2b8b74db4d09a886cf1363187 
> 
> 
> Diff: https://reviews.apache.org/r/73360/diff/2/
> 
> 
> Testing
> -------
> 
> Validated changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 73360: RANGER-3287 : Implement best practices for logging.

Posted by Ramesh Mani <rm...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73360/#review223015
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On May 20, 2021, 12:15 p.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73360/
> -----------------------------------------------------------
> 
> (Updated May 20, 2021, 12:15 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3287
>     https://issues.apache.org/jira/browse/RANGER-3287
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Implement best practices for logging
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java fb892d5c1c3ea6a2b8b74db4d09a886cf1363187 
> 
> 
> Diff: https://reviews.apache.org/r/73360/diff/2/
> 
> 
> Testing
> -------
> 
> Validated changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 73360: RANGER-3287 : Implement best practices for logging.

Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73360/
-----------------------------------------------------------

(Updated May 20, 2021, 12:15 p.m.)


Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Updated changes as recommended


Bugs: RANGER-3287
    https://issues.apache.org/jira/browse/RANGER-3287


Repository: ranger


Description
-------

Implement best practices for logging


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java fb892d5c1c3ea6a2b8b74db4d09a886cf1363187 


Diff: https://reviews.apache.org/r/73360/diff/2/

Changes: https://reviews.apache.org/r/73360/diff/1-2/


Testing
-------

Validated changes locally.


Thanks,

Vishal Suvagia

Re: Review Request 73360: RANGER-3287 : Implement best practices for logging.

Posted by Ramesh Mani <rm...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73360/#review223008
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java
Lines 324 (patched)
<https://reviews.apache.org/r/73360/#comment312162>

    Nit pick: consider doing this
    		logger.debug("PropertiesUtil:[" + keyStr + "][" + (keyStr.contains("password") ? "********" : props.get(keyStr)) + "]");


- Ramesh Mani


On May 18, 2021, 8:13 p.m., Vishal Suvagia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73360/
> -----------------------------------------------------------
> 
> (Updated May 18, 2021, 8:13 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3287
>     https://issues.apache.org/jira/browse/RANGER-3287
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Implement best practices for logging
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java fb892d5c1c3ea6a2b8b74db4d09a886cf1363187 
> 
> 
> Diff: https://reviews.apache.org/r/73360/diff/1/
> 
> 
> Testing
> -------
> 
> Validated changes locally.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>