[GitHub] [camel-website] zregvart commented on a change in pull request #444: CAMEL-15335: update the search layout design

[GitBox <gi...@apache.org>]

zregvart commented on a change in pull request #444:
URL: https://github.com/apache/camel-website/pull/444#discussion_r463986800



##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -375,13 +375,33 @@ body {
 
 #search_results {
   top: 3.38rem;
-  background: #fffe;
+  background: #fff;

Review comment:
       ```suggestion
     background: var(--navbar-background);
   ```

##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -390,15 +410,45 @@ body {
   padding-right: 0.5rem;
 }
 
+#search_results div.result {
+  padding: 0.25rem;
+  pointer-events: none;
+}
+
+#search_results div.result:hover {
+  background: var(--color-smoke-50);
+}
+
+#search_results div.section {
+  display: flex;
+}
+

Review comment:
       This was causing scrollbars to show
   
   ```suggestion
   
     #search_results dl {
       margin: 0;
     }
   ```

##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -412,9 +462,22 @@ body {
   padding-top: 0.3rem;
 }
 
+#search_results div.footer-search {
+  display: inline-flex;
+  float: right;
+  margin-right: 0.75rem;

Review comment:
       `float` doesn't make sense in flex layout, better to use padding vs margin so not to introduce scrollbars
   
   ```suggestion
     padding: .75rem;
     width: 100%;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org