You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/11 12:10:52 UTC

[GitHub] [skywalking-python] Humbertzhang commented on a change in pull request #63: [Plugin] check version of packages when install plugins

Humbertzhang commented on a change in pull request #63:
URL: https://github.com/apache/skywalking-python/pull/63#discussion_r468532218



##########
File path: skywalking/plugins/__init__.py
##########
@@ -38,7 +41,64 @@ def install():
             continue
         logger.debug('installing plugin %s', modname)
         plugin = importer.find_module(modname).load_module(modname)
+
+        ok = pkg_version_check(plugin, modname)
+        if not ok:

Review comment:
       Is it ok to log `logger.debug('checking version for plugin %s', modname)` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org