[GitHub] [beam] damondouglas commented on a change in pull request #15740: [BEAM-12936][Playground] Code editor - Docker container

[GitBox <gi...@apache.org>]

damondouglas commented on a change in pull request #15740:
URL: https://github.com/apache/beam/pull/15740#discussion_r731967699



##########
File path: playground/frontend/Dockerfile
##########
@@ -0,0 +1,39 @@
+###############################################################################
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+# limitations under the License.
+###############################################################################
+
+FROM debian:11 as build
+ENV FLUTTER_VERSION=2.5.2-stable
+
+RUN apt-get update && apt-get install -y wget xz-utils git protobuf-compiler
+RUN wget https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_$FLUTTER_VERSION.tar.xz &&\
+    tar -xf flutter_linux_$FLUTTER_VERSION.tar.xz &&\
+    mv flutter /opt/ &&\
+    ln -s /opt/flutter/bin/flutter /usr/bin/flutter &&\
+    ln -s /opt/flutter/bin/dart /usr/bin/dart &&\
+    dart pub global activate protoc_plugin &&\
+    ln -s /root/.pub-cache/bin/protoc-gen-dart /usr/bin/
+
+
+COPY . /app
+WORKDIR /app
+RUN mkdir lib/generated && protoc playground.proto --dart_out=grpc:lib/generated --proto_path=$(pwd)/playground/v1

Review comment:
       Why do we need to run protoc if the client/server stubs are already version controlled in the repository?

##########
File path: playground/frontend/nginx_default.conf
##########
@@ -0,0 +1,61 @@
+###############################################################################
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+# limitations under the License.
+###############################################################################
+
+server {

Review comment:
       Doesn't appengine flex already have a managed service ingress?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org