You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by mi...@apache.org on 2016/02/16 12:47:38 UTC
[4/6] git commit: [flex-sdk] [refs/heads/develop] - FLEX-33058
Renaming some variables to clarify intent and increase readability.
FLEX-33058
Renaming some variables to clarify intent and increase readability.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/7c8f7f52
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/7c8f7f52
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/7c8f7f52
Branch: refs/heads/develop
Commit: 7c8f7f525f8f3dc7c450f7b4378c3242a989cb7e
Parents: 4967c6b
Author: Mihai Chira <mi...@apache.org>
Authored: Tue Feb 16 10:37:49 2016 +0100
Committer: Mihai Chira <mi...@apache.org>
Committed: Tue Feb 16 10:37:49 2016 +0100
----------------------------------------------------------------------
.../advancedgrids/src/mx/collections/GroupingCollection2.as | 2 --
.../src/mx/collections/HierarchicalCollectionViewCursor.as | 8 ++++----
2 files changed, 4 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7c8f7f52/frameworks/projects/advancedgrids/src/mx/collections/GroupingCollection2.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/advancedgrids/src/mx/collections/GroupingCollection2.as b/frameworks/projects/advancedgrids/src/mx/collections/GroupingCollection2.as
index cf7eab7..6ceeac7 100644
--- a/frameworks/projects/advancedgrids/src/mx/collections/GroupingCollection2.as
+++ b/frameworks/projects/advancedgrids/src/mx/collections/GroupingCollection2.as
@@ -1212,8 +1212,6 @@ public class GroupingCollection2 extends HierarchicalData implements IGroupingCo
// initialize the variables
initialize();
-
-
if ((source as ICollectionView).length == 0)
return false;
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7c8f7f52/frameworks/projects/advancedgrids/src/mx/collections/HierarchicalCollectionViewCursor.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/advancedgrids/src/mx/collections/HierarchicalCollectionViewCursor.as b/frameworks/projects/advancedgrids/src/mx/collections/HierarchicalCollectionViewCursor.as
index 1f3244d..ee6268b 100644
--- a/frameworks/projects/advancedgrids/src/mx/collections/HierarchicalCollectionViewCursor.as
+++ b/frameworks/projects/advancedgrids/src/mx/collections/HierarchicalCollectionViewCursor.as
@@ -317,19 +317,19 @@ public class HierarchicalCollectionViewCursor extends EventDispatcher
* @playerversion AIR 1.1
* @productversion Flex 3
*/
- public function findAny(values:Object):Boolean
+ public function findAny(valuesToMatch:Object):Boolean
{
seek(CursorBookmark.FIRST);
var done:Boolean = false;
while (!done)
{
- var o:Object = hierarchicalData.getData(current);
+ var currentData:Object = hierarchicalData.getData(current);
var matches:Boolean = true;
- for (var p:String in values)
+ for (var property:String in valuesToMatch)
{
- if (o[p] != values[p])
+ if (valuesToMatch[property] != currentData[property])
{
matches = false;
break;