You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Ishan Chattopadhyaya (Jira)" <ji...@apache.org> on 2023/01/12 00:27:00 UTC
[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675756#comment-17675756 ]
Ishan Chattopadhyaya commented on SOLR-16347:
---------------------------------------------
The deadline has passed, but there has been no improvement to the degradation. However, a solution (per-configset-Jersey app) was identified and will be worked upon in a separate PR.
I feel this should reverted now to allow for performance testing to resume (without needed hacks of maintaining flags), and all of it be brought back along with the proper fix, once it is reviewed and tested. But, I withdraw my veto for now [0].
[0]- https://issues.apache.org/jira/browse/SOLR-16531?focusedCommentId=17675755&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17675755
> Add JAX-RS integration for defining v2 APIs
> -------------------------------------------
>
> Key: SOLR-16347
> URL: https://issues.apache.org/jira/browse/SOLR-16347
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: v2 API
> Affects Versions: main (10.0)
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> SOLR-15182 rewrote our v2 APIs to use annotations using an existing (in-house) framework. But continuing to use a homegrown framework is less than ideal for a few reasons:
> # Our in-house framework doesn't integrate with 3rd-party tooling like OpenAPI.
> # It gives us less functionality than many off-the-shelf frameworks, at a higher maintenance cost.
> # The current framework is less explicit about API inputs and outputs than many off-the-shelf alternatives, making code less clear and readable for developers.
> (For more on the pros/cons and for different evaluations on the tradeoff here, see [this|https://lists.apache.org/thread/6wx2vzfnmfgkw03b7s450zfp7yhrlz8f] long-running dev@ thread.)
> The work done by SOLR-15182 makes the jump to JAX-RS reasonably straightforward on an individual API basis: once the framework is in place switching a given API to JAX-RS is mostly a matter of swapping out our homegrown annotations for those recognized by JAX-RS and changing API method signatures to better represent the API inputs/outputs.
> We should integrate Jersey or a similar JAX-RS implementation and start cutting over v2 APIs to this new mode of definition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org