You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/15 14:01:43 UTC
[GitHub] [doris] cambyzju opened a new pull request, #11798: [fix](group_concat) group_concat be crash in vectorized engine
cambyzju opened a new pull request, #11798:
URL: https://github.com/apache/doris/pull/11798
# Proposed changes
Issue Number: close #7288
## Problem summary
The key points to reproduce the problem:
1. create table with string NOT NULL column;
2. call left join with group_concat;
The reason is because:
1. aggregate function framework pick combined null function by arguments type;
2. as the input argument is NOT NULL, so the origin group_concat is selected;
3. as a result, we need to consider insert_result_into with input column = ColumnNullabe(ColumnString);
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
4. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
6. Does it need to update dependencies:
- [ ] Yes
- [ ] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju closed pull request #11798: [fix](group_concat) group_concat be crash in vectorized engine
Posted by GitBox <gi...@apache.org>.
cambyzju closed pull request #11798: [fix](group_concat) group_concat be crash in vectorized engine
URL: https://github.com/apache/doris/pull/11798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on pull request #11798: [fix](group_concat) group_concat be crash in vectorized engine
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #11798:
URL: https://github.com/apache/doris/pull/11798#issuecomment-1215197109
https://github.com/apache/doris/pull/11700 already fix this case from FE side.
Make sure input column type is always nullabe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org