You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "scottyaslan (via GitHub)" <gi...@apache.org> on 2023/04/14 17:26:31 UTC
[GitHub] [nifi] scottyaslan opened a new pull request, #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
scottyaslan opened a new pull request, #7174:
URL: https://github.com/apache/nifi/pull/7174
…dencies
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-11433](https://issues.apache.org/jira/browse/NIFI-11433)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 11
- [ ] JDK 17
### Licensing
- [X] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [X] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [X] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] scottyaslan commented on a diff in pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #7174:
URL: https://github.com/apache/nifi/pull/7174#discussion_r1170334993
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor.js:
##########
@@ -1140,9 +1188,9 @@
*/
get: function (id) {
if (nfCommon.isUndefined(id)) {
- return processorMap.values();
+ return Array.from(processorMap.values());
} else {
- return processorMap.get(id);
+ return processoMap.get(id);
Review Comment:
You found the misplaced 'r'!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] koccs commented on a diff in pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "koccs (via GitHub)" <gi...@apache.org>.
koccs commented on code in PR #7174:
URL: https://github.com/apache/nifi/pull/7174#discussion_r1169924327
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-connection.js:
##########
@@ -1089,37 +1117,42 @@
if (!nfCommon.isBlank(connectionNameValue)) {
// see if the connection name label is already rendered
if (connectionName.empty()) {
- connectionName = connectionLabelContainer.append('g')
- .attrs({
+ connectionName = d3Helpers.multiAttr(
Review Comment:
Nit picking, but there is only one attribute here, you could use `.attr()` instead of the helper method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] sardell commented on pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "sardell (via GitHub)" <gi...@apache.org>.
sardell commented on PR #7174:
URL: https://github.com/apache/nifi/pull/7174#issuecomment-1513082058
Reviewing now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] scottyaslan commented on a diff in pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #7174:
URL: https://github.com/apache/nifi/pull/7174#discussion_r1170335400
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor.js:
##########
@@ -69,7 +72,7 @@
// -----------------------------------------------------------
// cache for components that are added/removed from the canvas
- // -----------------------------------------------------------
+ // ------------------------r-----------------------------------
Review Comment:
Yes, lol. Shane found where it goes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] koccs commented on a diff in pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "koccs (via GitHub)" <gi...@apache.org>.
koccs commented on code in PR #7174:
URL: https://github.com/apache/nifi/pull/7174#discussion_r1170164370
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor.js:
##########
@@ -69,7 +72,7 @@
// -----------------------------------------------------------
// cache for components that are added/removed from the canvas
- // -----------------------------------------------------------
+ // ------------------------r-----------------------------------
Review Comment:
I assume this change was unintentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mr1716 commented on pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "mr1716 (via GitHub)" <gi...@apache.org>.
mr1716 commented on PR #7174:
URL: https://github.com/apache/nifi/pull/7174#issuecomment-1512659140
Think this would take care or not of the owasp dependency check findings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache merged pull request #7174: [NIFI-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "mtien-apache (via GitHub)" <gi...@apache.org>.
mtien-apache merged PR #7174:
URL: https://github.com/apache/nifi/pull/7174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] scottyaslan commented on a diff in pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #7174:
URL: https://github.com/apache/nifi/pull/7174#discussion_r1170338240
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-component-version.js:
##########
@@ -96,9 +96,9 @@
*/
var resetDialog = function () {
// clear the versions
- var versions = versionMap.keys();
+ var versions = Array.from(versionMap.keys());
$.each(versions, function (_, version) {
- versionMap.remove(version);
+ versionMap['delete'](version);
Review Comment:
The yui compressor does not like `.delete()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] koccs commented on a diff in pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "koccs (via GitHub)" <gi...@apache.org>.
koccs commented on code in PR #7174:
URL: https://github.com/apache/nifi/pull/7174#discussion_r1169910360
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-component-version.js:
##########
@@ -96,9 +96,9 @@
*/
var resetDialog = function () {
// clear the versions
- var versions = versionMap.keys();
+ var versions = Array.from(versionMap.keys());
$.each(versions, function (_, version) {
- versionMap.remove(version);
+ versionMap['delete'](version);
Review Comment:
Why did you use string indexer? It should be simply [`.delete()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/delete)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] sardell commented on a diff in pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "sardell (via GitHub)" <gi...@apache.org>.
sardell commented on code in PR #7174:
URL: https://github.com/apache/nifi/pull/7174#discussion_r1170122858
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor.js:
##########
@@ -1140,9 +1188,9 @@
*/
get: function (id) {
if (nfCommon.isUndefined(id)) {
- return processorMap.values();
+ return Array.from(processorMap.values());
} else {
- return processorMap.get(id);
+ return processoMap.get(id);
Review Comment:
```suggestion
return processorMap.get(id);
```
This typo currently breaks updating processor configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] koccs commented on a diff in pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "koccs (via GitHub)" <gi...@apache.org>.
koccs commented on code in PR #7174:
URL: https://github.com/apache/nifi/pull/7174#discussion_r1170162373
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-status-history.js:
##########
@@ -356,8 +356,8 @@
// add status history details
var detailsContainer = buildDetailsContainer('Status History');
- d3.map(statusHistory.details).each(function (value, label) {
- addDetailItem(detailsContainer, label, value);
+ Object.keys(statusHistory.details).forEach(function(key) {
+ addDetailItem(detailsContainer, key, statusHistory.details[key]);
Review Comment:
[`Object.entries()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries) would provide a `[key, value]` pair, so you won't need the accessor for the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "mtien-apache (via GitHub)" <gi...@apache.org>.
mtien-apache commented on PR #7174:
URL: https://github.com/apache/nifi/pull/7174#issuecomment-1513535831
Reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] koccs commented on a diff in pull request #7174: [NIFIF-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "koccs (via GitHub)" <gi...@apache.org>.
koccs commented on code in PR #7174:
URL: https://github.com/apache/nifi/pull/7174#discussion_r1171107839
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-status-history.js:
##########
@@ -356,8 +356,8 @@
// add status history details
var detailsContainer = buildDetailsContainer('Status History');
- Object.keys(statusHistory.details).forEach(function(key) {
- addDetailItem(detailsContainer, key, statusHistory.details[key]);
+ Object.keys(statusHistory.details).forEach(function(key, value) {
Review Comment:
The method here should be `.entries`.
```suggestion
Object.entries(statusHistory.details).forEach(function(key, value) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on pull request #7174: [NIFI-11433] update angular, d3, moment, slickgrid, and jquery depen…
Posted by "mtien-apache (via GitHub)" <gi...@apache.org>.
mtien-apache commented on PR #7174:
URL: https://github.com/apache/nifi/pull/7174#issuecomment-1520546884
@scottyaslan Thanks for all the updates. Looks good now! Will merge shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org