You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Manjesh Nilange (JIRA)" <ji...@apache.org> on 2011/07/13 19:59:00 UTC
[jira] [Created] (TS-875) TSFetchRestpGet(), TSFetchPageResptGet()
and TSFetchUrl() have incorrect asserts
TSFetchRestpGet(), TSFetchPageResptGet() and TSFetchUrl() have incorrect asserts
--------------------------------------------------------------------------------
Key: TS-875
URL: https://issues.apache.org/jira/browse/TS-875
Project: Traffic Server
Issue Type: Bug
Components: TS API
Affects Versions: 3.0.0
Reporter: Manjesh Nilange
The asserts cause TS to crash when these API functions are used. The asserts are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM pointer as apparent in the code that follows.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-875) TSFetchRestpGet(), TSFetchPageResptGet()
and TSFetchUrl() have incorrect asserts
Posted by "Igor Galić (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić updated TS-875:
--------------------------
Backport to Version: (was: 3.0.1)
Fix Version/s: 3.0.1
> TSFetchRestpGet(), TSFetchPageResptGet() and TSFetchUrl() have incorrect asserts
> --------------------------------------------------------------------------------
>
> Key: TS-875
> URL: https://issues.apache.org/jira/browse/TS-875
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.0.0
> Reporter: Manjesh Nilange
> Assignee: Leif Hedstrom
> Fix For: 3.1.0, 3.0.1
>
> Attachments: inkapi.patch
>
>
> The asserts cause TS to crash when these API functions are used. The asserts are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM pointer as apparent in the code that follows.
> And TSFetchUrl allows continuations to make requests with no callbacks and for such code paths, the continuation check should not be done.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-875) TSFetchRestpGet(), TSFetchPageResptGet()
and TSFetchUrl() have incorrect asserts
Posted by "Manjesh Nilange (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjesh Nilange updated TS-875:
-------------------------------
Description:
The asserts cause TS to crash when these API functions are used. The asserts are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM pointer as apparent in the code that follows.
And TSFetchUrl allows continuations to make requests with no callbacks and for such code paths, the continuation check should not be done.
was:The asserts cause TS to crash when these API functions are used. The asserts are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM pointer as apparent in the code that follows.
> TSFetchRestpGet(), TSFetchPageResptGet() and TSFetchUrl() have incorrect asserts
> --------------------------------------------------------------------------------
>
> Key: TS-875
> URL: https://issues.apache.org/jira/browse/TS-875
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.0.0
> Reporter: Manjesh Nilange
> Attachments: inkapi.patch
>
>
> The asserts cause TS to crash when these API functions are used. The asserts are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM pointer as apparent in the code that follows.
> And TSFetchUrl allows continuations to make requests with no callbacks and for such code paths, the continuation check should not be done.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-875) TSFetchRestpGet(), TSFetchPageResptGet()
and TSFetchUrl() have incorrect asserts
Posted by "Manjesh Nilange (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manjesh Nilange updated TS-875:
-------------------------------
Attachment: inkapi.patch
Patch for InkAPI.cc
> TSFetchRestpGet(), TSFetchPageResptGet() and TSFetchUrl() have incorrect asserts
> --------------------------------------------------------------------------------
>
> Key: TS-875
> URL: https://issues.apache.org/jira/browse/TS-875
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.0.0
> Reporter: Manjesh Nilange
> Attachments: inkapi.patch
>
>
> The asserts cause TS to crash when these API functions are used. The asserts are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM pointer as apparent in the code that follows.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-875) TSFetchRestpGet(), TSFetchPageResptGet()
and TSFetchUrl() have incorrect asserts
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-875:
-----------------------------
Backport to Version: 3.0.1
Fix Version/s: 3.1.0
Assignee: Leif Hedstrom
> TSFetchRestpGet(), TSFetchPageResptGet() and TSFetchUrl() have incorrect asserts
> --------------------------------------------------------------------------------
>
> Key: TS-875
> URL: https://issues.apache.org/jira/browse/TS-875
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.0.0
> Reporter: Manjesh Nilange
> Assignee: Leif Hedstrom
> Fix For: 3.1.0
>
> Attachments: inkapi.patch
>
>
> The asserts cause TS to crash when these API functions are used. The asserts are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM pointer as apparent in the code that follows.
> And TSFetchUrl allows continuations to make requests with no callbacks and for such code paths, the continuation check should not be done.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-875) TSFetchRestpGet(), TSFetchPageResptGet()
and TSFetchUrl() have incorrect asserts
Posted by "Igor Galić (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić resolved TS-875.
---------------------------
Resolution: Fixed
> TSFetchRestpGet(), TSFetchPageResptGet() and TSFetchUrl() have incorrect asserts
> --------------------------------------------------------------------------------
>
> Key: TS-875
> URL: https://issues.apache.org/jira/browse/TS-875
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.0.0
> Reporter: Manjesh Nilange
> Assignee: Leif Hedstrom
> Fix For: 3.1.0, 3.0.1
>
> Attachments: inkapi.patch
>
>
> The asserts cause TS to crash when these API functions are used. The asserts are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM pointer as apparent in the code that follows.
> And TSFetchUrl allows continuations to make requests with no callbacks and for such code paths, the continuation check should not be done.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-875) TSFetchRestpGet(),
TSFetchPageResptGet() and TSFetchUrl() have incorrect asserts
Posted by "Manjesh Nilange (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064808#comment-13064808 ]
Manjesh Nilange commented on TS-875:
------------------------------------
Yeah, ideally they should be a different data type.
P.S. As of now, I don't have enough bandwidth to be an active committer and I don't want to be a passive committer again. That's why I'm contributing via this route. Let's see, maybe in the future that may change.
> TSFetchRestpGet(), TSFetchPageResptGet() and TSFetchUrl() have incorrect asserts
> --------------------------------------------------------------------------------
>
> Key: TS-875
> URL: https://issues.apache.org/jira/browse/TS-875
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.0.0
> Reporter: Manjesh Nilange
> Attachments: inkapi.patch
>
>
> The asserts cause TS to crash when these API functions are used. The asserts are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM pointer as apparent in the code that follows.
> And TSFetchUrl allows continuations to make requests with no callbacks and for such code paths, the continuation check should not be done.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-875) TSFetchRestpGet(),
TSFetchPageResptGet() and TSFetchUrl() have incorrect asserts
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064740#comment-13064740 ]
Leif Hedstrom commented on TS-875:
----------------------------------
That's not confusing at all :) Why are the APIs using TSHttpTxn as the input parameter in the first place?. Wish we had seen this before 3.0, and we could have changed that. Now your "fix" is correct, but I'm wondering if we should deprecate these APIs, and replace them with something that takes an appropriate parameter?
P.s You should email private@ :-).
> TSFetchRestpGet(), TSFetchPageResptGet() and TSFetchUrl() have incorrect asserts
> --------------------------------------------------------------------------------
>
> Key: TS-875
> URL: https://issues.apache.org/jira/browse/TS-875
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.0.0
> Reporter: Manjesh Nilange
> Attachments: inkapi.patch
>
>
> The asserts cause TS to crash when these API functions are used. The asserts are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM pointer as apparent in the code that follows.
> And TSFetchUrl allows continuations to make requests with no callbacks and for such code paths, the continuation check should not be done.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TS-875) TSFetchRestpGet(), TSFetchPageResptGet()
and TSFetchUrl() have incorrect asserts
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reopened TS-875:
------------------------------
Reopening, since we'll want to commit this for 3.0.1 if it passes the votes.
> TSFetchRestpGet(), TSFetchPageResptGet() and TSFetchUrl() have incorrect asserts
> --------------------------------------------------------------------------------
>
> Key: TS-875
> URL: https://issues.apache.org/jira/browse/TS-875
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Affects Versions: 3.0.0
> Reporter: Manjesh Nilange
> Assignee: Leif Hedstrom
> Fix For: 3.1.0
>
> Attachments: inkapi.patch
>
>
> The asserts cause TS to crash when these API functions are used. The asserts are incorrect as argument 'txnp' is actually not a transaction, but a FetchSM pointer as apparent in the code that follows.
> And TSFetchUrl allows continuations to make requests with no callbacks and for such code paths, the continuation check should not be done.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira