[GitHub] [pulsar] BewareMyPower edited a comment on pull request #11557: [C++/Python] Fix bugs that were not exposed by broken C++ CI before

[GitBox <gi...@apache.org>]

BewareMyPower edited a comment on pull request #11557:
URL: https://github.com/apache/pulsar/pull/11557#issuecomment-893114564


   > > > Introduced from Fix getting partition metadata of a nonexistent topic returns 0 #10601 because it changed the behavior of the admin API to get partition metadata while the C++ implementation relies on the original behavior to create topics automatically. So any test that uses HTTP lookup will fail.
   > > 
   > > 
   > > @BewareMyPower I think that is still a problem. If the compatibility with older c++ client was broken, we should roll it back and find a better way to solve the original issue.
   > 
   > For example, we could attempt at detecting that is the old C++ client and defaulting the `checkAllowAutoCreation=true` on the broker side.
   
   It's hard to detect whether the client is C++ client because the HTTP request doesn't contain any client related info. For older C++ client, we need to create topics manually in advance.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org