You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Steven Ingram <st...@gmail.com> on 2019/12/04 02:07:04 UTC
"Apply Code Changes" with JDK 11
I was happy to see recently that we can run the head of master with JDK
11. I can build and run the app with JDK 11 (this is new info in the
project README).
Unfortunately I was thwarted this evening by the Ant complaint about using
anything higher than JDK 8 to build the app when Debugging and using the
"Apply Code Changes" button.
"...You are attempting to build NetBeans using JDK 9 (or higher).
This is forbidden..."
I'm thinking this is just a bug now that we can apply code changes with JDK
11. I even tried to kick off my debugging session like so:
sudo ant -Ddebug.port=9009 -Dpermit.jdk9.builds=true tryme
But it didn't give the results I wanted/expected. The ant command that ran
from hitting "Apply Code Changes" is this:
"ant -f /Users/steveningram/Projects/incubator-netbeans/groovy/gradle
-Dfix.class=org/netbeans/modules/gradle/ActionProviderImpl debug-fix-nb"
I'm trying to fix an issue for my first pull request, otherwise I would try
and fix this issue on my own. I could also make a Jira if need be. Is
there any documentation on proper ticket creation?
I could even attempt to fix it with a little direction.
Regards,
Steven
Re: "Apply Code Changes" with JDK 11
Posted by Steven Ingram <st...@gmail.com>.
Thanks Matthias.
I'm not sure we are exactly on the same page, but adding the flag to the
config worked for me.
Thank you.
Steven
On Wed, Dec 4, 2019 at 1:21 AM Matthias Bläsing <mb...@doppel-helix.eu>
wrote:
> Hi,
>
> Am Dienstag, den 03.12.2019, 21:07 -0500 schrieb Steven Ingram:
> > I was happy to see recently that we can run the head of master with JDK
> > 11. I can build and run the app with JDK 11 (this is new info in the
> > project README).
> >
> > Unfortunately I was thwarted this evening by the Ant complaint about
> using
> > anything higher than JDK 8 to build the app when Debugging and using the
> > "Apply Code Changes" button.
> >
> > "...You are attempting to build NetBeans using JDK 9 (or higher).
> > This is forbidden..."
> >
> > I'm thinking this is just a bug now that we can apply code changes with
> JDK
> > 11. I even tried to kick off my debugging session like so:
> >
> > sudo ant -Ddebug.port=9009 -Dpermit.jdk9.builds=true tryme
> >
> > But it didn't give the results I wanted/expected. The ant command that
> ran
> > from hitting "Apply Code Changes" is this:
> >
> > "ant -f /Users/steveningram/Projects/incubator-netbeans/groovy/gradle
> > -Dfix.class=org/netbeans/modules/gradle/ActionProviderImpl debug-fix-nb"
> >
> > I'm trying to fix an issue for my first pull request, otherwise I would
> try
> > and fix this issue on my own. I could also make a Jira if need be. Is
> > there any documentation on proper ticket creation?
> >
> > I could even attempt to fix it with a little direction.
> >
>
> you are not seeing an error, but the normal behavior of the build
> system. For apply code changes to work, the code first needs to be
> build. It is this phase where you are hitting the warning (just as you
> would when you build the module/netbeans).
>
> Create either a file (depending on how broad you want to configure
> this):
>
> $HOME/.nbbuild.properties
> or
> $NB_SOURCE/nbbuild/user.build.properties
> or
> $NB_SOURCE/nbbuild/site.build.properties
>
> and put this into the file:
>
> permit.jdk9.builds=true
>
>
> I assume, that the property is known (elso building would fail) - the
> files are included from:
>
> $NB_SOURCE/nbbuild/default-properties.xml
>
> HTH
>
> Matthias
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: "Apply Code Changes" with JDK 11
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hi,
Am Dienstag, den 03.12.2019, 21:07 -0500 schrieb Steven Ingram:
> I was happy to see recently that we can run the head of master with JDK
> 11. I can build and run the app with JDK 11 (this is new info in the
> project README).
>
> Unfortunately I was thwarted this evening by the Ant complaint about using
> anything higher than JDK 8 to build the app when Debugging and using the
> "Apply Code Changes" button.
>
> "...You are attempting to build NetBeans using JDK 9 (or higher).
> This is forbidden..."
>
> I'm thinking this is just a bug now that we can apply code changes with JDK
> 11. I even tried to kick off my debugging session like so:
>
> sudo ant -Ddebug.port=9009 -Dpermit.jdk9.builds=true tryme
>
> But it didn't give the results I wanted/expected. The ant command that ran
> from hitting "Apply Code Changes" is this:
>
> "ant -f /Users/steveningram/Projects/incubator-netbeans/groovy/gradle
> -Dfix.class=org/netbeans/modules/gradle/ActionProviderImpl debug-fix-nb"
>
> I'm trying to fix an issue for my first pull request, otherwise I would try
> and fix this issue on my own. I could also make a Jira if need be. Is
> there any documentation on proper ticket creation?
>
> I could even attempt to fix it with a little direction.
>
you are not seeing an error, but the normal behavior of the build
system. For apply code changes to work, the code first needs to be
build. It is this phase where you are hitting the warning (just as you
would when you build the module/netbeans).
Create either a file (depending on how broad you want to configure
this):
$HOME/.nbbuild.properties
or
$NB_SOURCE/nbbuild/user.build.properties
or
$NB_SOURCE/nbbuild/site.build.properties
and put this into the file:
permit.jdk9.builds=true
I assume, that the property is known (elso building would fail) - the
files are included from:
$NB_SOURCE/nbbuild/default-properties.xml
HTH
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: "Apply Code Changes" with JDK 11
Posted by Steven Ingram <st...@gmail.com>.
Thanks Laszlo,
I'll hang on to this gem for sure!
"tryme.jdkhome=/usr/lib/jvm/java-13-openjdk-amd64"
Steven
On Wed, Dec 4, 2019 at 11:57 AM Laszlo Kishalmi <la...@gmail.com>
wrote:
> Well I'm working with NetBeans Running on JDK 13
>
> I have the following setting in nbbuild/user.build.properties:
>
> nbjdk.home=/usr/lib/jvm/java-8-openjdk-amd64
> tryme.jdkhome=/usr/lib/jvm/java-13-openjdk-amd64
>
> So I can compile comfortably on JDK 8 in the IDE, but test on JDK 13
> (Needed for creating good screenshot without the font antialiasing bug)
>
> On 12/3/19 6:07 PM, Steven Ingram wrote:
> > I was happy to see recently that we can run the head of master with JDK
> > 11. I can build and run the app with JDK 11 (this is new info in the
> > project README).
> >
> > Unfortunately I was thwarted this evening by the Ant complaint about
> using
> > anything higher than JDK 8 to build the app when Debugging and using the
> > "Apply Code Changes" button.
> >
> > "...You are attempting to build NetBeans using JDK 9 (or higher).
> > This is forbidden..."
> >
> > I'm thinking this is just a bug now that we can apply code changes with
> JDK
> > 11. I even tried to kick off my debugging session like so:
> >
> > sudo ant -Ddebug.port=9009 -Dpermit.jdk9.builds=true tryme
> >
> > But it didn't give the results I wanted/expected. The ant command that
> ran
> > from hitting "Apply Code Changes" is this:
> >
> > "ant -f /Users/steveningram/Projects/incubator-netbeans/groovy/gradle
> > -Dfix.class=org/netbeans/modules/gradle/ActionProviderImpl debug-fix-nb"
> >
> > I'm trying to fix an issue for my first pull request, otherwise I would
> try
> > and fix this issue on my own. I could also make a Jira if need be. Is
> > there any documentation on proper ticket creation?
> >
> > I could even attempt to fix it with a little direction.
> >
> > Regards,
> > Steven
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: "Apply Code Changes" with JDK 11
Posted by Laszlo Kishalmi <la...@gmail.com>.
Well I'm working with NetBeans Running on JDK 13
I have the following setting in nbbuild/user.build.properties:
nbjdk.home=/usr/lib/jvm/java-8-openjdk-amd64
tryme.jdkhome=/usr/lib/jvm/java-13-openjdk-amd64
So I can compile comfortably on JDK 8 in the IDE, but test on JDK 13
(Needed for creating good screenshot without the font antialiasing bug)
On 12/3/19 6:07 PM, Steven Ingram wrote:
> I was happy to see recently that we can run the head of master with JDK
> 11. I can build and run the app with JDK 11 (this is new info in the
> project README).
>
> Unfortunately I was thwarted this evening by the Ant complaint about using
> anything higher than JDK 8 to build the app when Debugging and using the
> "Apply Code Changes" button.
>
> "...You are attempting to build NetBeans using JDK 9 (or higher).
> This is forbidden..."
>
> I'm thinking this is just a bug now that we can apply code changes with JDK
> 11. I even tried to kick off my debugging session like so:
>
> sudo ant -Ddebug.port=9009 -Dpermit.jdk9.builds=true tryme
>
> But it didn't give the results I wanted/expected. The ant command that ran
> from hitting "Apply Code Changes" is this:
>
> "ant -f /Users/steveningram/Projects/incubator-netbeans/groovy/gradle
> -Dfix.class=org/netbeans/modules/gradle/ActionProviderImpl debug-fix-nb"
>
> I'm trying to fix an issue for my first pull request, otherwise I would try
> and fix this issue on my own. I could also make a Jira if need be. Is
> there any documentation on proper ticket creation?
>
> I could even attempt to fix it with a little direction.
>
> Regards,
> Steven
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists