[GitHub] [ignite-extensions] dorozhKing commented on a change in pull request #41: IGNITE-13029 Ignite Spring Data autoconfiguration

[GitBox <gi...@apache.org>]

dorozhKing commented on a change in pull request #41:
URL: https://github.com/apache/ignite-extensions/pull/41#discussion_r580390764



##########
File path: modules/spring-boot-autoconfigure-ext/pom.xml
##########
@@ -56,6 +56,20 @@
             <scope>provided</scope>
         </dependency>
 
+        <dependency>
+            <groupId>org.apache.ignite</groupId>
+            <artifactId>ignite-spring-data_2.2-ext</artifactId>

Review comment:
       I wrote some thoughts about it in my comment in PR https://github.com/apache/ignite-extensions/pull/41#issue-565370788 
   In additional, spring-context 5.2.3 (used in ignite-spring-data_2.2-ext) incompatible with spring-context 5.0.16 (used in ignite-spring-data_2.0-ext) and I should make exclusion it from ignite-spring-data_2.0-ext. But if I do it and write some tests like IgniteAutoconfigureTest this test will be failed with NoSuchMethodError due to incompatibility spring-context.
   May be additional maven profile can help but should I do this? It may be too complex.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org