[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5772: add user info in url to auth header in HTTP getDownloadFileRequest

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #5772:
URL: https://github.com/apache/incubator-pinot/pull/5772#discussion_r463227671



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -326,6 +327,11 @@ private static HttpUriRequest getSegmentCompletionProtocolRequest(URI uri, int s
   private static HttpUriRequest getDownloadFileRequest(URI uri, int socketTimeoutMs) {
     RequestBuilder requestBuilder = RequestBuilder.get(uri).setVersion(HttpVersion.HTTP_1_1);
     setTimeout(requestBuilder, socketTimeoutMs);
+    if (uri.getUserInfo() != null) {

Review comment:
       create a variable for uri.getUserInfo




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org